openstack/puppet-nova
Code Issues Proposed changes

Merge "Validate ensure parameter for package resources"

Browse Source
This commit is contained in:
Zuul
2025-09-26 03:53:22 +00:00
committed by Gerrit Code Review
parent 89f14bd6eb 56f8a011c6
commit 0da5add448
16 changed files with 99 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
manifests/api.pp
View File

@@ -136,35 +136,35 @@
# Defaults to undef
#
class nova::api (
Boolean $enabled = true,
Boolean $manage_service = true,
$api_paste_config = 'api-paste.ini',
$ensure_package = 'present',
Boolean $sync_db = true,
Boolean $sync_db_api = true,
Boolean $db_online_data_migrations = false,
$service_name = $nova::params::api_service_name,
$metadata_service_name = $nova::params::api_metadata_service_name,
$enable_proxy_headers_parsing = $facts['os_service_default'],
$max_request_body_size = $facts['os_service_default'],
$max_limit = $facts['os_service_default'],
$compute_link_prefix = $facts['os_service_default'],
$glance_link_prefix = $facts['os_service_default'],
$enable_instance_password = $facts['os_service_default'],
$password_length = $facts['os_service_default'],
$allow_resize_to_same_host = $facts['os_service_default'],
$instance_list_per_project_cells = $facts['os_service_default'],
$instance_list_cells_batch_strategy = $facts['os_service_default'],
$instance_list_cells_batch_fixed_size = $facts['os_service_default'],
$list_records_by_skipping_down_cells = $facts['os_service_default'],
Boolean $enabled = true,
Boolean $manage_service = true,
$api_paste_config = 'api-paste.ini',
Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $sync_db = true,
Boolean $sync_db_api = true,
Boolean $db_online_data_migrations = false,
$service_name = $nova::params::api_service_name,
$metadata_service_name = $nova::params::api_metadata_service_name,
$enable_proxy_headers_parsing = $facts['os_service_default'],
$max_request_body_size = $facts['os_service_default'],
$max_limit = $facts['os_service_default'],
$compute_link_prefix = $facts['os_service_default'],
$glance_link_prefix = $facts['os_service_default'],
$enable_instance_password = $facts['os_service_default'],
$password_length = $facts['os_service_default'],
$allow_resize_to_same_host = $facts['os_service_default'],
$instance_list_per_project_cells = $facts['os_service_default'],
$instance_list_cells_batch_strategy = $facts['os_service_default'],
$instance_list_cells_batch_fixed_size = $facts['os_service_default'],
$list_records_by_skipping_down_cells = $facts['os_service_default'],
# DEPRECATED PARAMETERS
$api_bind_address = undef,
$osapi_compute_listen_port = undef,
$metadata_listen = undef,
$metadata_listen_port = undef,
$enabled_apis = undef,
$osapi_compute_workers = undef,
$metadata_workers = undef,
$api_bind_address = undef,
$osapi_compute_listen_port = undef,
$metadata_listen = undef,
$metadata_listen_port = undef,
$enabled_apis = undef,
$osapi_compute_workers = undef,
$metadata_workers = undef,
) inherits nova::params {
include nova::deps
include nova::db

2
manifests/client.pp
View File

@@ -9,7 +9,7 @@
# Defaults to 'present'
#
class nova::client (
$ensure = 'present'
Stdlib::Ensure::Package $ensure = 'present',
) {
include nova::deps
include nova::params

2
manifests/compute.pp
View File

@@ -265,7 +265,7 @@
class nova::compute (
Boolean $enabled = true,
Boolean $manage_service = true,
$ensure_package = 'present',
Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $vnc_enabled = true,
Boolean $spice_enabled = false,
$vncserver_proxyclient_address = $facts['os_service_default'],

4
manifests/compute/ironic.pp
View File

@@ -13,8 +13,8 @@
# Defaults to 'ironic.IronicDriver'
#
class nova::compute::ironic (
$ensure_package = 'present',
$compute_driver = 'ironic.IronicDriver',
Stdlib::Ensure::Package $ensure_package = 'present',
$compute_driver = 'ironic.IronicDriver',
) {
include nova::deps
require nova::ironic::common

2
manifests/compute/libvirt.pp
View File

@@ -244,7 +244,7 @@
# Defaults to undef
#
class nova::compute::libvirt (
$ensure_package = 'present',
Stdlib::Ensure::Package $ensure_package = 'present',
Nova::VirtType $virt_type = 'kvm',
String[1] $vncserver_listen = '127.0.0.1',
Boolean $migration_support = false,

26
manifests/compute/libvirt/services.pp
View File

@@ -58,19 +58,19 @@
# Defaults to false
#
class nova::compute::libvirt::services (
$ensure_package = 'present',
$libvirt_service_name = $nova::params::libvirt_service_name,
$virtlock_service_name = $nova::params::virtlock_service_name,
$virtlog_service_name = $nova::params::virtlog_service_name,
$libvirt_virt_type = 'kvm',
$modular_libvirt = $nova::params::modular_libvirt,
$virtsecret_service_name = $nova::params::virtsecret_socket_name,
$virtnodedev_service_name = $nova::params::virtnodedev_socket_name,
$virtqemu_service_name = $nova::params::virtqemu_socket_name,
$virtproxy_service_name = $nova::params::virtproxy_socket_name,
$virtstorage_service_name = $nova::params::virtstorage_socket_name,
Boolean $manage_ovmf = true,
Boolean $manage_swtpm = false,
Stdlib::Ensure::Package $ensure_package = 'present',
$libvirt_service_name = $nova::params::libvirt_service_name,
$virtlock_service_name = $nova::params::virtlock_service_name,
$virtlog_service_name = $nova::params::virtlog_service_name,
$libvirt_virt_type = 'kvm',
$modular_libvirt = $nova::params::modular_libvirt,
$virtsecret_service_name = $nova::params::virtsecret_socket_name,
$virtnodedev_service_name = $nova::params::virtnodedev_socket_name,
$virtqemu_service_name = $nova::params::virtqemu_socket_name,
$virtproxy_service_name = $nova::params::virtproxy_socket_name,
$virtstorage_service_name = $nova::params::virtstorage_socket_name,
Boolean $manage_ovmf = true,
Boolean $manage_swtpm = false,
) inherits nova::params {
include nova::deps
include nova::params

2
manifests/compute/libvirt_guests.pp
View File

@@ -69,7 +69,7 @@
#
class nova::compute::libvirt_guests (
Boolean $enabled = false,
$package_ensure = 'present',
Stdlib::Ensure::Package $package_ensure = 'present',
Enum['start', 'ignore'] $on_boot = 'ignore',
Enum['suspend', 'shutdown'] $on_shutdown = 'shutdown',
Optional[Integer[0]] $start_delay = undef,

4
manifests/compute/rbd.pp
View File

@@ -112,8 +112,8 @@ class nova::compute::rbd (
$libvirt_rbd_destroy_volume_retries = $facts['os_service_default'],
Boolean $ephemeral_storage = true,
Boolean $manage_ceph_client = true,
$ceph_client_ensure = 'present',
$package_ensure = 'present',
Stdlib::Ensure::Package $ceph_client_ensure = 'present',
Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_libvirt_secret = true,
) {
include nova::deps

10
manifests/conductor.pp
View File

@@ -28,11 +28,11 @@
# Defaults to $facts['os_service_default']
#
class nova::conductor (
Boolean $enabled = true,
Boolean $manage_service = true,
$ensure_package = 'present',
$workers = $facts['os_workers'],
$enable_new_services = $facts['os_service_default'],
Boolean $enabled = true,
Boolean $manage_service = true,
Stdlib::Ensure::Package $ensure_package = 'present',
$workers = $facts['os_workers'],
$enable_new_services = $facts['os_service_default'],
) {
include nova::deps
include nova::db

6
manifests/generic_service.pp
View File

@@ -33,9 +33,9 @@
define nova::generic_service (
$package_name,
$service_name,
Boolean $enabled = true,
Boolean $manage_service = true,
$ensure_package = 'present'
Boolean $enabled = true,
Boolean $manage_service = true,
Stdlib::Ensure::Package $ensure_package = 'present',
) {
include nova::deps
include nova::params

2
manifests/init.pp
View File

@@ -352,7 +352,7 @@
# Defaults to $facts['os_service_default']
#
class nova (
$ensure_package = 'present',
Stdlib::Ensure::Package $ensure_package = 'present',
$default_transport_url = $facts['os_service_default'],
$rpc_response_timeout = $facts['os_service_default'],
$long_rpc_timeout = $facts['os_service_default'],

2
manifests/scheduler.pp
View File

@@ -69,7 +69,7 @@
class nova::scheduler (
Boolean $enabled = true,
Boolean $manage_service = true,
$ensure_package = 'present',
Stdlib::Ensure::Package $ensure_package = 'present',
$workers = $facts['os_workers'],
$max_attempts = $facts['os_service_default'],
$discover_hosts_in_cells_interval = $facts['os_service_default'],

10
manifests/serialproxy.pp
View File

@@ -25,11 +25,11 @@
# Defaults to 'present'
#
class nova::serialproxy (
Boolean $enabled = true,
Boolean $manage_service = true,
$serialproxy_host = $facts['os_service_default'],
$serialproxy_port = $facts['os_service_default'],
$ensure_package = 'present'
Boolean $enabled = true,
Boolean $manage_service = true,
$serialproxy_host = $facts['os_service_default'],
$serialproxy_port = $facts['os_service_default'],
Stdlib::Ensure::Package $ensure_package = 'present',
) {
include nova::deps
include nova::params

10
manifests/spicehtml5proxy.pp
View File

@@ -29,11 +29,11 @@
# Defaults to 'present'
#
class nova::spicehtml5proxy (
Boolean $enabled = true,
Boolean $manage_service = true,
$host = '0.0.0.0',
$port = '6082',
$ensure_package = 'present'
Boolean $enabled = true,
Boolean $manage_service = true,
$host = '0.0.0.0',
$port = '6082',
Stdlib::Ensure::Package $ensure_package = 'present',
) {
include nova::deps
include nova::params

2
manifests/vncproxy.pp
View File

@@ -67,7 +67,7 @@ class nova::vncproxy (
String[1] $host = '0.0.0.0',
Stdlib::Port $port = 6080,
String $vncproxy_path = '/vnc_auto.html',
$ensure_package = 'present',
Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $allow_noauth = true,
Boolean $allow_vencrypt = false,
$vencrypt_key = undef,

58
manifests/wsgi/apache_metadata.pp
View File

@@ -141,35 +141,35 @@
# class { 'nova::wsgi::apache_metadata': }
#
class nova::wsgi::apache_metadata (
$servername = $facts['networking']['fqdn'],
$port = 8775,
$bind_host = undef,
$path = '/',
$ssl = false,
$workers = $facts['os_workers'],
$ssl_cert = undef,
$ssl_key = undef,
$ssl_chain = undef,
$ssl_ca = undef,
$ssl_crl_path = undef,
$ssl_crl = undef,
$ssl_certs_dir = undef,
$wsgi_process_display_name = undef,
$threads = 1,
$priority = 10,
$ensure_package = 'present',
$access_log_file = undef,
$access_log_pipe = undef,
$access_log_syslog = undef,
$access_log_format = undef,
$access_log_env_var = undef,
$error_log_file = undef,
$error_log_pipe = undef,
$error_log_syslog = undef,
$custom_wsgi_process_options = {},
$headers = undef,
$request_headers = undef,
$vhost_custom_fragment = undef,
$servername = $facts['networking']['fqdn'],
$port = 8775,
$bind_host = undef,
$path = '/',
$ssl = false,
$workers = $facts['os_workers'],
$ssl_cert = undef,
$ssl_key = undef,
$ssl_chain = undef,
$ssl_ca = undef,
$ssl_crl_path = undef,
$ssl_crl = undef,
$ssl_certs_dir = undef,
$wsgi_process_display_name = undef,
$threads = 1,
$priority = 10,
Stdlib::Ensure::Package $ensure_package = 'present',
$access_log_file = undef,
$access_log_pipe = undef,
$access_log_syslog = undef,
$access_log_format = undef,
$access_log_env_var = undef,
$error_log_file = undef,
$error_log_pipe = undef,
$error_log_syslog = undef,
$custom_wsgi_process_options = {},
$headers = undef,
$request_headers = undef,
$vhost_custom_fragment = undef,
) {
include nova::params