openstack/puppet-nova
Code Issues Proposed changes

migraton/libvirt: fix dependency cycle

Browse Source 
In the last commit, I introduced a dependency cyle:
(File_line[/etc/sysconfig/libvirtd libvirtd args] => Service[libvirt] =>
Class[Nova::Compute::Libvirt] => File_line[/etc/sysconfig/libvirtd
libvirtd args])

The "require" is useless, since the migration class is called by
nova::compute::libvirt, let's delete it.

Change-Id: I97aeb9dcc11bb867e020826ad9ed5d7d0e04a8e8
This commit is contained in:
Emilien Macchi
2014-10-16 15:20:41 -04:00
parent 94235f6d83
commit 3ffc5a2631
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/migration/libvirt.pp
View File

@@ -34,7 +34,6 @@ class nova::migration::libvirt {
line => 'LIBVIRTD_ARGS="--listen"',
match => 'LIBVIRTD_ARGS=',
notify => Service['libvirt'],
require => Class['nova::compute::libvirt'],
}
Package['libvirt'] -> File_line<| path == '/etc/sysconfig/libvirtd' |>
@@ -66,7 +65,6 @@ class nova::migration::libvirt {
line => 'libvirtd_opts="-d -l"',
match => 'libvirtd_opts=',
notify => Service['libvirt'],
require => Class['nova::compute::libvirt'],
}
Package['libvirt'] -> File_line<| path == "/etc/default/${::nova::compute::libvirt::libvirt_service_name}" |>