openstack/puppet-nova
Code Issues Proposed changes

Set defaults in nova::scheduler::filter to os_service_default

Browse Source 
Change-Id: Ia47e32fd62bea506e71fa2ad33d3cb7ed4e3e45b
This commit is contained in:
Tobias Urdin
2023-09-15 14:10:24 +00:00
committed by Tobias Urdin
parent 0cf7b86bc9
commit 466d4fb325
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/scheduler/filter.pp
View File

@@ -129,9 +129,9 @@ class nova::scheduler::filter (
$max_instances_per_host = $facts['os_service_default'],
$isolated_images = $facts['os_service_default'],
$isolated_hosts = $facts['os_service_default'],
Array[String[1]] $available_filters = ['nova.scheduler.filters.all_filters'],
$available_filters = $facts['os_service_default'],
$enabled_filters = $facts['os_service_default'],
$weight_classes = 'nova.scheduler.weights.all_weighers',
$weight_classes = $facts['os_service_default'],
$track_instance_changes = $facts['os_service_default'],
$ram_weight_multiplier = $facts['os_service_default'],
$cpu_weight_multiplier = $facts['os_service_default'],

6
releasenotes/notes/nova-scheduler-filter-defaults-23de047328dfd629.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
upgrade:
- |
The default value for parameters ``available_filters`` and ``weight_classes``
in the ``nova::scheduler::filter`` class has been changed to the ``os_service_default``
fact as their defaults was redundant.

4
spec/classes/nova_scheduler_filter_spec.rb
View File

@@ -12,8 +12,8 @@ describe 'nova::scheduler::filter' do
it { is_expected.to contain_nova_config('filter_scheduler/host_subset_size').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/max_io_ops_per_host').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/max_instances_per_host').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/available_filters').with_value(['nova.scheduler.filters.all_filters']) }
it { is_expected.to contain_nova_config('filter_scheduler/weight_classes').with_value('nova.scheduler.weights.all_weighers') }
it { is_expected.to contain_nova_config('filter_scheduler/available_filters').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/weight_classes').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/isolated_images').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/isolated_hosts').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('filter_scheduler/enabled_filters').with_value('<SERVICE DEFAULT>') }