openstack/puppet-nova
Code Issues Proposed changes

Merge "Add an ability to manage use_stderr parameter"

Browse Source
This commit is contained in:
Jenkins
2015-08-12 07:18:30 +00:00
committed by Gerrit Code Review
parent cade2b7a5f 4190d9d108
commit 4c1a34d720
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/init.pp
View File

@@ -187,6 +187,10 @@
# (optional) Use syslog for logging
# Defaults to false
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to true
#
# [*log_facility*]
# (optional) Syslog facility to receive log lines.
# Defaults to 'LOG_USER'
@@ -312,6 +316,7 @@ class nova(
$nova_public_key = undef,
$nova_private_key = undef,
$use_syslog = false,
$use_stderr = true,
$log_facility = 'LOG_USER',
$install_utilities = true,
$notification_driver = [],
@@ -613,6 +618,7 @@ class nova(
nova_config {
'DEFAULT/verbose': value => $verbose;
'DEFAULT/debug': value => $debug;
'DEFAULT/use_stderr': value => $use_stderr;
'DEFAULT/rpc_backend': value => $rpc_backend;
'DEFAULT/notification_driver': value => $notification_driver_real;
'DEFAULT/notification_topics': value => $notification_topics;

1
spec/classes/nova_init_spec.rb
View File

@@ -70,6 +70,7 @@ describe 'nova' do
it 'configures various things' do
is_expected.to contain_nova_config('DEFAULT/verbose').with_value(false)
is_expected.to contain_nova_config('DEFAULT/debug').with_value(false)
is_expected.to contain_nova_config('DEFAULT/use_stderr').with_value(true)
is_expected.to contain_nova_config('DEFAULT/log_dir').with_value('/var/log/nova')
is_expected.to contain_nova_config('DEFAULT/state_path').with_value('/var/lib/nova')
is_expected.to contain_nova_config('DEFAULT/lock_path').with_value(platform_params[:lock_path])