openstack/puppet-nova
Code Issues Proposed changes

[vmware] host_password should be secret

Browse Source 
... because the parameter accepts the password as a plain text.

Change-Id: I17031d66b5cdadc579c23c735233cb6ab28f0b7c
This commit is contained in:
Takashi Kajinami
2022-03-01 22:07:02 +09:00
parent da1383a880
commit 71cd1dd31c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/compute/vmware.pp
View File

@@ -79,7 +79,7 @@ class nova::compute::vmware(
'DEFAULT/compute_driver': value => $compute_driver;
'vmware/host_ip': value => $host_ip;
'vmware/host_username': value => $host_username;
'vmware/host_password': value => $host_password;
'vmware/host_password': value => $host_password, secret => true;
'vmware/cluster_name': value => $cluster_name;
'vmware/api_retry_count': value => $api_retry_count;
'vmware/maximum_objects': value => $maximum_objects;

2
spec/classes/nova_compute_vmware_spec.rb
View File

@@ -26,7 +26,7 @@ describe 'nova::compute::vmware' do
is_expected.to contain_nova_config('DEFAULT/compute_driver').with_value('vmwareapi.VMwareVCDriver')
is_expected.to contain_nova_config('vmware/host_ip').with_value(params[:host_ip])
is_expected.to contain_nova_config('vmware/host_username').with_value(params[:host_username])
is_expected.to contain_nova_config('vmware/host_password').with_value(params[:host_password])
is_expected.to contain_nova_config('vmware/host_password').with_value(params[:host_password]).with_secret(true)
is_expected.to contain_nova_config('vmware/cluster_name').with_value(params[:cluster_name])
is_expected.to contain_nova_config('vmware/api_retry_count').with_value(5)
is_expected.to contain_nova_config('vmware/maximum_objects').with_value(100)