Remove deprecated nova::image_service

This parameter was deprecated long ago[1] and has had no effect, so
we're ready to remove it.

[1] b9bb76c089
Change-Id: I550d12ecdae7d9a14cc0d56fdf1bd43bebbe6e85

manifests/init.pp

@@ -397,9 +397,6 @@
 #
 # DEPRECATED PARAMETERS
 #
-# [*image_service*]
-#   (optional) Service used to search for and retrieve images.
-#
 # [*auth_strategy*]
 #   (optional) The strategy to use for auth: noauth or keystone.
 #   Defaults to undef
@@ -516,7 +513,6 @@ class nova(
   $my_ip                                  = $::os_service_default,
   $cross_az_attach                        = $::os_service_default,
   # DEPRECATED PARAMETERS
-  $image_service                          = undef,
   $auth_strategy                          = undef,
   $glance_api_servers                     = undef,
   $database_min_pool_size                 = undef,
@@ -545,11 +541,6 @@ in a future release. Use nova::cinder::os_region_name instead')
 in a future release. Use nova::cinder::catalog_info instead')
   }
 
-  if $image_service {
-    warning('The unused image_service parameter is deprecated, as we are \
-already using python-glanceclient instead of old glance client.')
-  }
-
   if $upgrade_level_console != undef {
     warning('The upgrade_level_console parameter is deprecated, and has \
 no effect.')

releasenotes/notes/remove-nova-image_service-850481867b070ce9.yaml

@@ -0,0 +1,4 @@
+---
+upgrade:
+  - |
+    The deprecated ``nova::image_service`` parameter has been removed.