openstack/puppet-nova
Code Issues Proposed changes

Missing some parameters to test in db.pp

Browse Source 
Add max_pool_size and max_overflow options to test.

Change-Id: I45699d43aa7a6f381296e4af311a1a5637d5f401
Closes-Bug: #1694871
This commit is contained in:
ZhongShengping
2017-06-01 11:18:55 +08:00
parent 5c79055fe0
commit b73afba774
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/classes/nova_db_spec.rb
View File

@@ -18,8 +18,10 @@ describe 'nova::db' do
it { is_expected.to_not contain_nova_config('placement_database/slave_connection') }
it { is_expected.to_not contain_nova_config('database/idle_timeout') }
it { is_expected.to_not contain_nova_config('database/min_pool_size') }
it { is_expected.to_not contain_nova_config('database/max_pool_size') }
it { is_expected.to_not contain_nova_config('database/max_retries') }
it { is_expected.to_not contain_nova_config('database/retry_interval') }
it { is_expected.to_not contain_nova_config('database/max_overflow') }
end
context 'with overriden parameters' do
@@ -40,8 +42,10 @@ describe 'nova::db' do
:db_max_retries => '<SERVICE DEFAULT>',
:idle_timeout => '<SERVICE DEFAULT>',
:min_pool_size => '<SERVICE DEFAULT>',
:max_pool_size => '<SERVICE DEFAULT>',
:max_retries => '<SERVICE DEFAULT>',
:retry_interval => '<SERVICE DEFAULT>',
:max_overflow => '<SERVICE DEFAULT>',
)}
it { is_expected.to contain_nova_config('api_database/connection').with_value('mysql+pymysql://user:pass@db/db2').with_secret(true) }
it { is_expected.to contain_nova_config('api_database/slave_connection').with_value('mysql+pymysql://user:pass@slave/db2').with_secret(true) }