The comment says that at most five key/value pairs are allowed but it is
not true, at least not true any more, based on some experiments. This
patch fixes the comment to avoid confusion.
Change-Id: I098ded910a6c7c2a7f967e6afe14e93d231d7ace
When adding block device with swap format, size is in MB and for
other formats it is in GB, so help is modified to show correct
description
Change-Id: I0472f2a86ed2a2a651d7bbb08976e8813fb72041
Closes-Bug: #1407383
The Nova V3 API no longer exists. Although a version of the framework
exists in Nova as part of the new V2.1 API which is equivalent to
the V2 API there is no need to make mention of V3 in the novaclient
documentation.
In future we will be distinguish between legacy Nova API support (one
implementation of V2) and microversions Nova API support (the
new one) to reduce confusion around version numbers which will change quite
a bit without the framework changing.
Co-Authored-By: Andrey Kurilin <akurilin@mirantis.com>
Change-Id: Id0ff51e1165cb267045d7a63aff13c0e41336738
The expected behavior is when timing is True, then we record each
request's time, then we should call reset_timings() to release memory.
However, the shell, client.{HTTPClient,SessionClient} will record each
request's time no matter what timing is set, then after long running
time in service like ceilometer-agent-compute, the memory keeps increasing.
We'd better not record request's time when timing is set to False.
Users are not responiable to call reset_timings() when they don't want
timing functionality.
Change-Id: I3e7d2fadf9a21be018781d528a1b6562228da6dd
Closes-Bug: #1433491
https://review.openstack.org/#/c/153203/3 added check
for novaclient, removed the logic for both
--image and --block-device are added.
But actually the following valid boot command failed
due to the change here, so this patch reverted original
one and add some descriptions to avoid further removal.
nova boot test-vm --flavor m1.medium --image centos-vm-32
--nic net-id=c3f40e33-d535-4217-916b-1450b8cd3987
--block-device id=26b7b917-2794-452a-95e5-2efb2ca6e32d,bus=sata,
source=volume,bootindex=1
Change-Id: Ia29e63c72b34d3038aa591c466425e65edf5755b
Partial-Bug: #1433609
Currently, several of the volumes apis depend on callers to pass
service_type='volume' as a parameter when creating a client object,
to route correctly. The problem is, it makes it impossible for
callers to work with both the compute and volume endpoints at the
same time. They can either work with compute and have volumes.* calls
return 404, or they can work with volume and have servers.* images.*
flavors.* calls return 404.
The CLI sets service_type='volume' for client objects for the
following commands via a decorator:
volume-list
volume-show
volume-create
volume-delete
volume-snapshot-list
volume-snapshot-show
volume-snapshot-create
volume-snapshot-delete
volume-type-list
volume-type-create
volume-type-delete
With this change, the service_type 'volume' is set in the api,
so the decorators on the shell commands are no longer needed.
Closes-Bug: #1431154
Change-Id: I11b48ac14fa4c64d8aae528552ec5b363be384c5
The min_count, max_count, and security_groups parameters for
servers.create are missing documentation. The security_groups
parameter was documented in the servers._boot function but that
private function isn't published to the docs.
This change adds the missing documentation for the aforementioned
parameters and removes the duplicate docs in the servers._boot
function.
Change-Id: Ib0dcc7e8f7f4d0b83b6caeddd1ace66add4e0003
After wanting to do a rather simple thing -- figure out of the
"timeout" argument to nodepool was a int or a float, it lead me down
the rabbit-hole to python-novaclient.
It turns out the timeout does get passed through to requests as a
float so that mystery was solved.
But the "Client" class seems to be missing from the documentation as
it's not included in the class list. So add that and also at least
document the types of the arguments.
However, then I noticd that this wasn't showing up; turns out sphinx
requires "autoclass_content = both" if you want it to document
__init__() functions. Several other classes had their init args
documented but they weren't showing up because of this.
Change-Id: I8f44e92f2a0f25a75926b1813a8b374e79b4f5db
Stop hard coding the default value for the injected_files quota and just
point to the quota instead.
Change-Id: Ia2abc7e4c3d0e5f954a5c09ff76f11a794e89695
The proper attribute name is 'IPPROTO_TCP', not 'IPROTO_TCP'.
This would lead to an AttributeError since socket does
not have an attribute named 'IPROTO_TCP'.
Change-Id: Ibd3c1e8d48ae57994d023bf18dd53a298466f6cb
Closes-Bug: 1430935
nova client is not able to show the list of volumes when
querying by name.This is because cinder api accepts only
display_name as query parameter and when qeried with 'name'
parameter returns a empty list
Change-Id: Ie4ffc275d1754052d9e239d8457baf6f7fd53b83
Closes-Bug: #1430415
The nova flavor-show command accepts a flavor
name as its parameter. The command show inconsistency
as it works with the exact flavor name and flavor name
in all lowercase but fails for any other case pattern.
So, updated the code so that if we run the command
with flavor-name case patern it runs fine.
Closes-Bug: #1423885
Change-Id: I713bf2b5aca977df40dc745e29d4fe98a950c991
The secgroup-{add,delete,list}-default-rules? family of commands has
confusing help text that makes it sounds like they actually operate on
the default security group (that is, the security group named
'default' which is the default for the current tenant). Instead, the
operate on a sort of meta-security-group object which is only used to
populate the 'default' security group in newly-created tenants. This
is crazy confusing. These commands get fancy new help strings that
should hopefully make it a little more clear.
Closes-Bug: 1430354
Change-Id: I4d9569ba7ea9ad7a20e984df7a137c99240a9748
Outline the background and goal of the functional testing. Want to make
sure there is consensus on how this should look. Next step is to
reorganize the functional tests to follow the plan outlined here.
Change-Id: I1d6889682f50f78b0681c99b77475adba95ef807
The following replacements were done:
1) assertEqual(True, *) -> assertTrue(*)
2) assertEqual(False, *) -> assertFalse(*)
3) assertTrue(a in b) -> assertIn(a, b)
4) assertTrue(* is not None) -> assertIsNotNone(*)
TrivialFix
Change-Id: I8d8a2d7b5d3505e07728544b683b301d1a8850cf
docs config contains variables 'version' and 'release', which is a little bit
outdated. Since these variables are not used, let's comment them(they can be
helpful in future).
Change-Id: I39f41002f69efc48841e7703b0c767bda0448c09
Unused code was removed in fixture_data/images.py
for unknown image requests that relate to
v2/images.py and test_images for them.
Change-Id: I7e31a572116b1e5cf0df9f431f8e53470d27d066
Resolved issues in python-novaclient code like
Function 'func_name' does not have a parameter 'param_name'
TrivialFix
Change-Id: I87cfd346ed8d7dd45bc4dc96bc89c576b5145711
Fix E124 failures and enable check for E124
E124 closing bracket does not match visual indentation
Change-Id: Iec6af44362dcf613cfaccbccbe53de82aba51a6a
other openstack clients like glance, cinder use --endpoint-type
(internal|admin|public). This allows users to use the same arguments
with the nova cli.
Partial-bug: #1367389
Change-Id: Ia55cad797ac0dca7fa60f55c1f2dfba0b64d0fd3
Fixed redeclared test_names for two test functions that pass now:
1) 'test_list_security_groups_all_tenants_on'
2) 'test_find_by_str_name'
Small spelling corrections
TrivialFix
Change-Id: Iacb0ce5697779f9342c22a22cb2f29a8e063b459
debugging tests is a lot easier when you can actually inject stderr
directly through even on successes. Add the pretty tox facility from
nova / tempest-lib into python-nova client as well for functional
tests.
Change-Id: I5c1f8244a5c743b590b74a8eb3eaf4a699555644
This is a functional test that boots a server via the cli, creates a
volume, and tries to attach it via the cli (which causes a failure due
to completion cache code). Note: the failure actually happens *after*
the attach command is dispatched, so the volume attach will still
work, the user is presented an error though.
Many TODOs remain for future patches. The test also tries to document
what was learned about the CLI redirection to cinder API, which was
introduced when Cinder was split out, but was tribal knowledge that
was lost in the mists of time.
Related-Bug: #1423695
Change-Id: Iaf474298be135843bff0114cf211bee19762f3ad
This reverts commit 4c8cefb98a425382204df2f38f24e6b5b71520dd.
The cache completion was causing a bug where 'nova volume-attach' would
then try to query Nova for volume information using a URL that was not
valid. This caused it to appear that the attach had failed.
Additionally the idea of making extra API queries for a bash completion
cache should be thought through more.
Conflicts:
novaclient/client.py
novaclient/shell.py
novaclient/v2/client.py
novaclient/v3/client.py
Closes-Bug: #1423695
Change-Id: I6676a11f9b5318a1cda2d03a5d4550bda549d5c2
