The proper attribute name is 'IPPROTO_TCP', not 'IPROTO_TCP'.
This would lead to an AttributeError since socket does
not have an attribute named 'IPROTO_TCP'.
Change-Id: Ibd3c1e8d48ae57994d023bf18dd53a298466f6cb
Closes-Bug: 1430935
Outline the background and goal of the functional testing. Want to make
sure there is consensus on how this should look. Next step is to
reorganize the functional tests to follow the plan outlined here.
Change-Id: I1d6889682f50f78b0681c99b77475adba95ef807
The following replacements were done:
1) assertEqual(True, *) -> assertTrue(*)
2) assertEqual(False, *) -> assertFalse(*)
3) assertTrue(a in b) -> assertIn(a, b)
4) assertTrue(* is not None) -> assertIsNotNone(*)
TrivialFix
Change-Id: I8d8a2d7b5d3505e07728544b683b301d1a8850cf
docs config contains variables 'version' and 'release', which is a little bit
outdated. Since these variables are not used, let's comment them(they can be
helpful in future).
Change-Id: I39f41002f69efc48841e7703b0c767bda0448c09
Unused code was removed in fixture_data/images.py
for unknown image requests that relate to
v2/images.py and test_images for them.
Change-Id: I7e31a572116b1e5cf0df9f431f8e53470d27d066
Resolved issues in python-novaclient code like
Function 'func_name' does not have a parameter 'param_name'
TrivialFix
Change-Id: I87cfd346ed8d7dd45bc4dc96bc89c576b5145711
Fix E124 failures and enable check for E124
E124 closing bracket does not match visual indentation
Change-Id: Iec6af44362dcf613cfaccbccbe53de82aba51a6a
other openstack clients like glance, cinder use --endpoint-type
(internal|admin|public). This allows users to use the same arguments
with the nova cli.
Partial-bug: #1367389
Change-Id: Ia55cad797ac0dca7fa60f55c1f2dfba0b64d0fd3
Fixed redeclared test_names for two test functions that pass now:
1) 'test_list_security_groups_all_tenants_on'
2) 'test_find_by_str_name'
Small spelling corrections
TrivialFix
Change-Id: Iacb0ce5697779f9342c22a22cb2f29a8e063b459
debugging tests is a lot easier when you can actually inject stderr
directly through even on successes. Add the pretty tox facility from
nova / tempest-lib into python-nova client as well for functional
tests.
Change-Id: I5c1f8244a5c743b590b74a8eb3eaf4a699555644
This is a functional test that boots a server via the cli, creates a
volume, and tries to attach it via the cli (which causes a failure due
to completion cache code). Note: the failure actually happens *after*
the attach command is dispatched, so the volume attach will still
work, the user is presented an error though.
Many TODOs remain for future patches. The test also tries to document
what was learned about the CLI redirection to cinder API, which was
introduced when Cinder was split out, but was tribal knowledge that
was lost in the mists of time.
Related-Bug: #1423695
Change-Id: Iaf474298be135843bff0114cf211bee19762f3ad
This reverts commit 4c8cefb98a425382204df2f38f24e6b5b71520dd.
The cache completion was causing a bug where 'nova volume-attach' would
then try to query Nova for volume information using a URL that was not
valid. This caused it to appear that the attach had failed.
Additionally the idea of making extra API queries for a bash completion
cache should be thought through more.
Conflicts:
novaclient/client.py
novaclient/shell.py
novaclient/v2/client.py
novaclient/v3/client.py
Closes-Bug: #1423695
Change-Id: I6676a11f9b5318a1cda2d03a5d4550bda549d5c2
Currently the commands of os-tenant-network API use net-*
which may confuse users sometime. This patch changes commands
to tenant-network-*, and marks net-* commands as DEPRECATED.
Closes-Bug: #1152862
Change-Id: I8c3a0be08763a6f626d7fc7cf84811ac61ccc526
Copy tests in from tempest/cli/simple_read_only/compute/test_nova.py in
preparation for removing that file.
Change-Id: I5a34cf1a39d4f73f94a27cce365434bd4a0eea0b
Nova delete command deletes an instance by name
or ID. Nova delete command is able to delete an
instance within the same the tenant by name or
ID. When admin credentials are sourced and try
to delete a non admin tenant instances, nova
delete command is able to delete an instance by
ID only, it is not able to delete an instance by
name.
Nova delete command deletes an instances by id
using following api call
/v2/{tenant_id}/servers/{server_id}
But to delete an instance by name, nova delete
command first find the resources by name using
following api call
/servers?name={server_name}
This api call is not able to retrive the list
of other tenant instances.
Adding all tenants parameter to this api call
will retrive the list of other tenant
instances. The following will be new api
call
/servers?all_tenants=1&name={server_name}
Closes-Bug: #1247030
Change-Id: I03e578d58214c835d9a411752bd618d77ced37ff
If 'auth_url' is missed in HTTPClient, authenticate method failed with
non-friendly error while trying to parse it.
Change-Id: Iaec95527293f3e1a34eb7f9ffa81097ba48107b3
nova help usage commands provides help that the command
can be used with either tenant name or tenant ID but using
tenant name gives wrong output.
So, updated the help for the command so that it is shown
that only tenant ID can be used.
Change-Id: I2ae1edd28d75fc7988fcd0da5b0fdd8081455b16
Closes-Bug: #1419726
If given filename is `-` for `--pub-key` option, reads public key
from stdin.
$ cat id_rsa.pub | nova keypair-add --pub-key - keyname
Change-Id: Ib6dfe5a7b08d588868a923defb9ddd15fc28e01f
Closes-Bug: #1333476
I observed a transient unit test failure [1] where occasionally the
ordering of the keys in the string result from json.dumps() didn't
match the ordering in the call_args_list, causing the test to fail.
This change adds a dict comparison of the POST data payload instead
of comparing the json.dumps(data) strings.
[1] http://logs.openstack.org/03/153203/3/check/
gate-python-novaclient-python34/f8a12bc/
Change-Id: I6b8bd4169b92870f657bf4e7f7fca02722749017
In the method named from_api in nova/block_device.py,
if source_type == 'image' and destination_type == 'local':
raise exception.InvalidBDMFormat(
details=_("Mapping image to local is not supported."))
While, in the method named _boot in novaclient/v2/servers.py
if image:
bdm_dict = {'uuid': image.id, 'source_type': 'image',
'destination_type': 'local', 'boot_index': 0,
'delete_on_termination': True}
block_device_mapping_v2.insert(0, bdm_dict)
Because of the above, if using --image and --block-device
params at the same time to create vm, nova would
raise InvalidBDMFormat exception
To resolve this problem, remove the codes in novaclient which
conflict with nova
Change-Id: I488322ba0160100a6d641fde68fa824d0581956a
Closes-Bug:#1418484
This fix changes the item that cached for completion from
"human_id" to "name".
A string for completion shoud not be changed in any way,
because changed keyword can not use as command line parameter.
But the "human_id" means "human readable id" that is
changed from "name" by method "to_slug". "to_slug" is meant to
create a valid path name from a string.
The tools/nova.bash_completion take the completion string from
the file ".novaclient/*/*-cache". The file is created when client
call "list" command. For example , "nova list","nova image-list",
and the others.
Currently, items that are written to the cache file is the "id"
and "human_id".
Closes-Bug: #1193049
Change-Id: I241ec8b7c8729274ee43db6e360141fd381b265e
Methods tests.v1_1.fakes.FakeHTTPClient.post_servers_1234_action
and tests.fixture_data.servers.V1.post_servers_1234_action
contain a set of same asserts. These asserts moved to method
check_server_actions. This method is shared between
post_servers_1234_action methods.
Some almost equal asserts are grouped.
Change-Id: I2643e77fe30400d462731bbc57351460fb28dc92
Currently find_resource() searches resource with human_id before does
with name_attr. With this logic, find_resource() cannot identify
upper/lower case. In find_resource(), human_id always matches and
name_attr never used in find_resource() because human_id made from
small letters of name_attr string (see bug/1318503).
To identify upper/lower case, name_attr should be used before human_id.
This fix moves name_attr to ahead of human_id with unit-test cases.
Change-Id: I9b821d7111c11a97be38f19de06172daf410022d
Closes-Bug: #1318503
Add first pass at getting a post_test_hook working. Once the project
config side of this lands this script can be self gating.
Change-Id: I5b0f5508f8e0a2a13f71e4a6b7a29a0d1a59b951
