openstack/python-openstackclient
Code Issues Proposed changes

Merge "Trivial: Remove unuseful comments for assertRaise() checking"

Browse Source
This commit is contained in:
Jenkins 2016-05-07 11:35:04 +00:00 committed by Gerrit Code Review
commit fbd48be2ac
5 changed files with 0 additions and 16 deletions

1
openstackclient/tests/compute/v2/test_server.py

@ -146,7 +146,6 @@ class TestServerCreate(TestServer):
('server_name', self.new_server.name),
]
# Missing required args should bail here
self.assertRaises(utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)

2
openstackclient/tests/network/v2/test_floating_ip.py

@ -88,7 +88,6 @@ class TestCreateFloatingIPNetwork(TestFloatingIPNetwork):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -314,7 +313,6 @@ class TestCreateFloatingIPCompute(TestFloatingIPCompute):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)

3
openstackclient/tests/network/v2/test_network.py

@ -112,7 +112,6 @@ class TestCreateNetworkIdentityV3(TestNetwork):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -599,7 +598,6 @@ class TestShowNetwork(TestNetwork):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -916,7 +914,6 @@ class TestShowNetworkCompute(TestNetworkCompute):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)

8
openstackclient/tests/network/v2/test_router.py

@ -47,7 +47,6 @@ class TestAddPortToRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -88,7 +87,6 @@ class TestAddSubnetToRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -154,7 +152,6 @@ class TestCreateRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -335,7 +332,6 @@ class TestRemovePortFromRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -375,7 +371,6 @@ class TestRemoveSubnetFromRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -475,7 +470,6 @@ class TestSetRouter(TestRouter):
('distributed', False),
]
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -534,7 +528,6 @@ class TestSetRouter(TestRouter):
('clear_routes', True),
]
# Argument parse failing should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -591,7 +584,6 @@ class TestShowRouter(TestRouter):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)

2
openstackclient/tests/network/v2/test_subnet_pool.py

@ -109,7 +109,6 @@ class TestCreateSubnetPool(TestSubnetPool):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@ -624,7 +623,6 @@ class TestShowSubnetPool(TestSubnetPool):
arglist = []
verifylist = []
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)