openstack/requirements
Code Issues Proposed changes

Add flake8-import-order to global-requirements.txt

Browse Source 
This commit adds flake8-import-order to global-requirements.txt. With
this library, we can check whether imports order is along with the
hacking import order template[1] automatically.

Of course, we can check import orders by manual. However it is not fun
and we sometimes mistake. And we have H306 rule for checking import
orders but it only checks alphabetic order not for stdlibs or not.

[1] http://docs.openstack.org/developer/hacking/#import-order-template

* Is the library actively maintained?

  Yes. This has been released constantly and maintained by Python Code
  Quality Authority. http://meta.pycqa.org/en/latest/management.html

* Is the library good code?

  Yes. It's simple enough.

* Is the library python 3 compatible?

  Yes.

* Is the library license compatible?

  Yes, the library is licensed as MIT.

* Is the library already packaged in the distros we target (Ubuntu
  latest / Fedora latest)?

  No. It's on pypi.

* Is the function of this library already covered by other libraries
  in global-requirements.txt?

  No.

* Is the library required for OpenStack project or related dev or
  infrastructure setup? Which?

  Tempest at this point: Iff75ebec42b295870edd1c04001adfb17460a682

Change-Id: Ia2140f5566ce169b076ffa5c9ebfbdbfc41e5bed
This commit is contained in:
Masayuki Igawa 2017-02-13 17:09:51 +09:00
parent 294b5464d0
commit 53e13b08f1
No known key found for this signature in database
GPG Key ID: 251CCDE9053850E4
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
blacklist.txt
View File

@ -2,6 +2,7 @@
# over time. # over time.
flake8 flake8
flake8_docstrings flake8_docstrings
flake8-import-order
hacking hacking
mccabe mccabe
pep257 pep257

1
global-requirements.txt
View File

@ -417,6 +417,7 @@ zake>=0.1.6 # Apache-2.0
# beyond this list would ever use a == # beyond this list would ever use a ==
flake8>=2.5.4,<2.6.0 # MIT flake8>=2.5.4,<2.6.0 # MIT
flake8_docstrings==0.2.1.post1 # MIT flake8_docstrings==0.2.1.post1 # MIT
flake8-import-order==0.11 # LGPLv3
hacking>=0.12.0,!=0.13.0,<0.14 # Apache-2.0 hacking>=0.12.0,!=0.13.0,<0.14 # Apache-2.0
mccabe==0.2.1 # MIT License mccabe==0.2.1 # MIT License
pep257==0.7.0 # MIT License pep257==0.7.0 # MIT License