Merge "update the review instructions for new lib releases"
This commit is contained in:
commit
a0e2d54e5c
15
README.rst
15
README.rst
@ -354,10 +354,17 @@ If the change was proposed by the OpenStack CI bot, then if the change has
|
|||||||
passed CI, only one reviewer is needed and they should +2 +A without thinking
|
passed CI, only one reviewer is needed and they should +2 +A without thinking
|
||||||
about things.
|
about things.
|
||||||
|
|
||||||
If the change was not proposed by the OpenStack CI bot, and does not include a
|
If the change was not proposed by the OpenStack CI bot, and only
|
||||||
``global-requirements.txt`` change, then it should be rejected: the CI bot
|
changes the ``upper-constraints.txt`` entry for a new library release,
|
||||||
will generate an appropriate change itself. Ask in #openstack-infra if the
|
then the change should be approved if it passes the tests. See the
|
||||||
bot needs to be run more quickly.
|
README.rst in openstack/releases for more details of the release
|
||||||
|
process.
|
||||||
|
|
||||||
|
If the change was not proposed by the OpenStack CI bot, and is not
|
||||||
|
related to releasing one of our libraries, and does not include a
|
||||||
|
``global-requirements.txt`` change, then it should be rejected: the CI
|
||||||
|
bot will generate an appropriate change itself. Ask in
|
||||||
|
#openstack-infra if the bot needs to be run more quickly.
|
||||||
|
|
||||||
Otherwise the change may be the result of recalculating the constraints which
|
Otherwise the change may be the result of recalculating the constraints which
|
||||||
changed when a ``global-requirements.txt`` change is proposed. In this case, ignore
|
changed when a ``global-requirements.txt`` change is proposed. In this case, ignore
|
||||||
|
Loading…
Reference in New Issue
Block a user