Use a better method to only check for human reviews.

This commit is contained in:
Russell Bryant 2013-06-28 13:20:16 -04:00
parent df6fe0e618
commit 3c16505fce

View File

@ -199,10 +199,7 @@ def find_oldest_no_nack(change):
for patch in reversed(change['patchSets']):
nacked = False
for review in patch.get('approvals', []):
if review['by'].get('username') == 'jenkins':
# Only consider nacks from people
continue
if review['type'] not in ('CRVW', 'VRIF'):
if review['type'] != 'CRVW':
continue
if review['value'] in ('-1', '-2'):
nacked = True