6638 Commits

Author SHA1 Message Date
Jenkins
6e893e2288 Merge "Drop unnecessary dereferencing" 2017-05-12 21:26:58 +00:00
Jenkins
4a19917827 Merge "Open-code eventlet.listen()" 2017-05-12 16:46:28 +00:00
Jenkins
145cfc3174 Merge "Fix domain_remap when obj starts/ends with slash" 2017-05-12 15:47:20 +00:00
Pete Zaitcev
cd2d359b02 Drop unnecessary dereferencing
The patch that introduced this (with my own help, no less),
also pasted these in tests, but someone else has already
cleaned that up.

Change-Id: I87c0a110831b5b5f75cb6fde1badec338f2150a9
2017-05-11 18:11:55 -06:00
Jenkins
1d09a02481 Merge "Remove links for EOLed releases" 2017-05-11 14:16:49 +00:00
Jenkins
7fd41f3db4 Merge "Update multi-node install links" 2017-05-11 14:01:20 +00:00
Tim Burke
3981e1ee8a Remove links for EOLed releases
Change-Id: If7e8526edf18b02474ba272451b9b4212558e03c
2017-05-11 13:57:10 +00:00
Clay Gerrard
37f6f25283 Update multi-node install links
... as is useful to do from time to time

Change-Id: I165899445080fa3a8e6dc624ab5a13680b819a73
2017-05-11 09:13:02 -04:00
Romain LE DISEZ
6db12b87ff Fix domain_remap when obj starts/ends with slash
domain_remap strip all starting/ending slashes. This behavior does not
allow to access objects starting or ending with slash. It is also
impacting staticweb middleware as staticweb tries to redirect
pseudo-directory to an URL with an ending slash, but as domain_remap
strip it, it goes to an infinite loop.

With this commit, the path of the request is passed as-is when
reconstructing the new request path. Example
http://www.example.com//obj/ was previously rewritten to
http://storage.example.com/v1/AUTH_abc/container/obj. It is now
rewritten to http://storage.example.com/v1/AUTH_abc/container//obj/

Closes-Bug: #1682293
Co-Authored-By: Christian Schwede <cschwede@redhat.com>
Change-Id: I1ef6b8752183d27103a3b0e720edcb4ce06fb837
2017-05-11 08:47:23 -04:00
Pete Zaitcev
5dfc3a75fb Open-code eventlet.listen()
Recently out gate started blowing up intermittently with a strange
case of ports mixed up. Sometimes a functional tests tries to
authorize on a port that's clearly an object server port, and
the like. As it turns out, eventlet developers added an unavoidable
SO_REUSEPORT into listen(), which makes listen(("localhost",0)
to reuse ports.

There's an issue about it:
 https://github.com/eventlet/eventlet/issues/411

This patch is working around the problem while eventlet people
consider the issue.

Change-Id: I67522909f96495a6a30e1acdb79835dce2189549
2017-05-11 01:39:14 -06:00
Jenkins
cd712cd144 Merge "Trivial fix typo and PEP 8 coding style violation" 2017-05-10 20:10:05 +00:00
Jenkins
1f36582efb Merge "Fix unit tests on i386 and other archs" 2017-05-10 19:58:45 +00:00
Jenkins
2abffb99b9 Merge "Fix sporadic failure in TestObjectController.test_container_update_async" 2017-05-10 14:51:35 +00:00
Ngo Quoc Cuong
cd50160191 Trivial fix typo and PEP 8 coding style violation
telemtry -> telemetry
PEP 8: line too long (81 > 79 characters)

Change-Id: I2f70f64a3a2cbf35e4a5250e1099f176670cb31f
2017-05-09 08:17:56 +07:00
Jenkins
7ebb2cdef7 Merge "Trivial fix typo while reading doc" 2017-05-06 10:17:18 +00:00
Jenkins
30898435b1 Merge "Stop including Connection header in EC GET responses" 2017-05-05 22:12:05 +00:00
Jenkins
7bbb80884d Merge "Add message to account-creation assertion" 2017-05-05 21:01:43 +00:00
Ngo Quoc Cuong
e23f8d3160 Trivial fix typo while reading doc
Change-Id: I9d96dd4464a086e508fbf18057b4f3e90c82c916
2017-05-05 23:06:14 +07:00
Tim Burke
50357de575 Fix sporadic failure in TestObjectController.test_container_update_async
Change-Id: Ie4d58626ebe97049703802a43c669cc78cf60f8b
Related-Change: I15f36e191cfe3ee6c82b4be56e8618ec0230e328
Closes-Bug: #1589994
2017-05-05 00:11:39 +00:00
Jenkins
4915a3a3f6 Merge "Remove the unused import code" 2017-05-04 20:33:28 +00:00
Tim Burke
4c8239503a Add message to account-creation assertion
We've seen some failures in the gate like

    ==============================
    Failed 1 tests - output below:
    ==============================

    setUpModule (test.functional.test_account)
    ------------------------------------------

    Captured traceback:
    ~~~~~~~~~~~~~~~~~~~
        Traceback (most recent call last):
          File "test/functional/test_account.py", line 33, in setUpModule
            tf.setup_package()
          File "test/functional/__init__.py", line 716, in setup_package
            mem_object_server if in_mem_obj else object_server))
          File "test/functional/__init__.py", line 621, in in_process_setup
            create_account(AUTH_test)
          File "test/functional/__init__.py", line 619, in create_account
            assert(resp.status == 201)
        AssertionError

...which aren't terribly useful in figuring out what went wrong.

Change-Id: I3cd31bb480dc8508828fe21416bfae33bc0985b7
2017-05-04 17:48:26 +00:00
Jenkins
dad1951ea8 Merge "Trivial fix for decrypter docstrings" 2017-05-04 13:45:03 +00:00
Jenkins
dd3bc8fe61 Merge "Move EC-specific unit test to EC Test class" 2017-05-03 23:20:36 +00:00
Jenkins
33a422af9f Merge "Fix (un)patch_policies" 2017-05-03 21:11:39 +00:00
Jenkins
0e58bfffac Merge "Trivial fix warnings in docstring" 2017-05-03 18:31:11 +00:00
Ngo Quoc Cuong
172c4de31d Trivial fix warnings in docstring
Single quoted docstring
Params and docstring are inconsistent

Change-Id: Ie41bd2960280491f0a5fbd55c6a1aabb328099b8
2017-05-03 18:30:14 +07:00
Alistair Coles
88ca232e52 Trivial fix for decrypter docstrings
Fix wrong param descriptions in decrypter.py
Fix missing param in base.py

Change-Id: I07fdfe2e7193afa4ee6b88a10f4ba58495b509b3
2017-05-03 11:41:14 +01:00
Jenkins
4e61735e53 Merge "Use LogRecord.msg instead of LogRecord.message in tests" 2017-05-03 10:36:02 +00:00
Jenkins
d7a6d6e1e9 Merge "Do not sync suffixes when remote rejects reconstructor revert" 2017-05-01 20:38:07 +00:00
Alistair Coles
6c320b2908 Stop including Connection header in EC GET responses
Currently, EC GET responses from proxy to clients, unlike any other
response, include a "Connection: close" header. If the client has sent
a "Connection: keep-alive" header then eventlet.wsgi appends this to
the client response, so clients can receive a response with both
headers:

Connection: close
Connection: keep-alive

This patch fixes the proxy EC GET path to remove any Connection header
from it's response, but does not change the behaviour of eventlet.wsgi
with respect to returning any client provided 'Connection: keep-alive'
header.

Change-Id: I43cd27c978edb4a1a587f031dbbee26e9acdc920
Co-Authored-By: Matthew Oliver <matt@oliver.net.au>
Closes-Bug:  #1680731
2017-05-01 18:21:18 +01:00
lijunbo
96bbd06134 Remove the unused import code
Remove the unused import in ssync_receiver.py

Change-Id: I81ef107201a79446f07e87ee04758c2bf251ebda
2017-05-01 18:43:03 +08:00
Jenkins
4f3ce4db31 Merge "Fix install guide filter:authtoken config example" 2017-05-01 10:17:58 +00:00
Tim Burke
387ce13aa1 Use LogRecord.msg instead of LogRecord.message in tests
From the docs for LogRecord.message [1],

> This is set when Formatter.format() is invoked.

Apparently we may find ourselves in a situation [2] where that never
happens? Really weird that it failed *midway* through the test though;
maybe some concurrent test removed all formatters?

ERROR: test_known_bad_ec_config
(test.unit.common.test_storage_policy.TestStoragePolicies)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File ".../test/unit/common/test_storage_policy.py", line 688, in test_known_bad_ec_config
    self.assertIn(msg, records[0].message)
AttributeError: 'LogRecord' object has no attribute 'message'

[1] https://docs.python.org/2/library/logging.html#logrecord-attributes
[2] http://logs.openstack.org/59/460359/1/check/gate-swift-tox-xfs-tmp-py27-ubuntu-xenial/5ecc2cb/console.html#_2017-04-27_01_06_43_346096
Change-Id: I8f5ac0ec1195a233f14edc0126de1d1cea7a6e2f
2017-04-28 15:56:25 -07:00
Colleen Murphy
93ca16c558 Fix install guide filter:authtoken config example
The name of the default domain in keystone is 'Default', not 'default',
which is its ID. If a user copy and pastes the user_domain_name and
project_domain_name settings from example [filter:authtoken] section
in the install guide, the first time they run 'swift stat' they will
meet a 401 error because keystone is trying to look up domains by name
rather than ID. This patch corrects the docs so that they are
copy-and-paste-proof, and also updates the keystone user creation
example to demonstrate the correct domain ID.

Change-Id: Ic595c2923b71d1c2ff2b4c9a773ea7742fdd029b
2017-04-28 15:05:45 +02:00
Jenkins
e1b74c83c4 Merge "Fix sporadic failure in TestAccountController unit test" 2017-04-28 03:19:26 +00:00
Matthew Oliver
a07f7dc8c0 Fix sporadic failure in TestAccountController unit test
The proxy server on occasion has error limited a node by the time the
test runs, causing the proxie's node_iter failing to iter out this
error limited  node. As the test uses a default FakeRing with no
extra handoffs, on this occasion we only get 2 requests which is not
enough for quorum, causing it to return a 503.

This patch sets the error_suppression_interval to 0 when creating
the proxy server. Meaning a node effectively isn't error_limited.

Change-Id: I96cf4c4d63594f803cc1cd57e874d1624db8e249
Closes-Bug: #1682026
2017-04-27 01:03:29 +00:00
Tim Burke
20072570d9 Fix sporadic failure in test/unit/obj/test_server.py
In particular, in TestObjectController.test_object_delete_at_async_update

Rarely (<0.1% of the time?), it would fail with:

======================================================================
FAIL: test_object_delete_at_async_update
(test.unit.obj.test_server.TestObjectController)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/vagrant/swift/test/unit/obj/test_server.py", line 4826, in
test_object_delete_at_async_update
    resp = req.get_response(self.object_controller)
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/vagrant/swift/test/unit/__init__.py", line 1075, in
mocked_http_conn
    raise AssertionError('left over status %r' % left_over_status)
AssertionError: left over status [500, 500]
-------------------- >> begin captured stdout << ---------------------
test INFO: None - - [26/Apr/2017:22:32:13 +0000] "PUT /sda1/p/a/c/o" 400
19 "-" "-" "-" 0.0003 "-" 23801 0

--------------------- >> end captured stdout << ----------------------
>>  raise AssertionError('left over status %r' % [500, 500])

----------------------------------------------------------------------

Related-Bug: 1514111
Change-Id: I1af4a291fb67cf4b1829f167998a08644117a800
2017-04-26 15:51:16 -07:00
Jenkins
408500320b Merge "authors/changelog for 2.14.0" 2017-04-26 21:31:14 +00:00
Jenkins
20f7e5f857 Merge "Improve test_get_valid_utf8_str coverage" 2017-04-26 20:09:04 +00:00
John Dickinson
29e2edf8de authors/changelog for 2.14.0
Change-Id: I0a6a8e4d62d2181e6d959437d6e84eeb2c29a05d
2017-04-26 11:46:18 -07:00
Jenkins
1f540de0f1 Merge "Update version in controller-install-rdo" 2017-04-26 14:38:48 +00:00
Jenkins
d15ed269c2 Merge "Update version from Newton to Ocata" 2017-04-26 11:10:38 +00:00
Jenkins
a852397578 Merge "Make add_dev complain louder about missing keys" 2017-04-26 07:14:22 +00:00
Clay Gerrard
6be5196fbe Make add_dev complain louder about missing keys
... and remove some cruft that couldn't possibly work

Change-Id: I560f0a29f0a881c63ec3cb910dbf5476fe2a915a
Related-Change-Id: I0d8928b55020592f8e75321d1f7678688301d797
2017-04-25 19:29:57 -07:00
lijunbo
a480f6c5f0 Update version from Newton to Ocata
Update version from newton to ocata in following files
 install-guide/controller-install-rdo.rst
 install-guide/source/controller-install-ubuntu.rst.

Change-Id: Ia0108e27d3498d3d6b546e6721e087db66eba4b0
2017-04-25 14:03:35 +00:00
Jenkins
da9cd16609 Merge "Update version in controller-install-ubuntu" 2017-04-25 09:54:10 +00:00
Jenkins
965ad372d5 Merge "Update version in controller-install-debian" 2017-04-25 09:54:02 +00:00
Jenkins
daa79e7de3 Merge "Update reno for stable/ocata" 2017-04-25 09:24:02 +00:00
Ondřej Nový
9e15effb3b Fix unit tests on i386 and other archs
Change-Id: I4f84b725e220e28919570fd7f296b63b34d0375d
2017-04-24 21:40:31 +00:00
Jenkins
bc92423150 Merge "Update version in finalize-installation-ubuntu" 2017-04-24 12:31:06 +00:00