This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also disables the facts gathering because this validation is
only using the package_facts.
Change-Id: I9ebed531fba6966a4122f0c55eac784cbb6954cc
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also disable the facts gathering because this validation
doesn't need them and only uses service_facts in the ntp role.
Change-Id: I3a19eb0a93f6dfaaf7a4361b46b2dc904aeb7ae6
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also disables the facts gathering because this validation
doesn't need them.
Change-Id: I99a506d17a2e76c9513745db877e5ce0ba3aae6a
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also disables the fact gathering as this validation doesn't
need them at all.
Change-Id: Ica37eb5a2b1edf883d701f523a12eb47264fed7c
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also fixes the facts gathering by being sure we get only the
needed facts.
Change-Id: Ifbe7bd73559b05f6655bfd396029c22345b75f4c
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch removes the README.md file and adds the documentation
directly in the sphinx role documentation index. All variables have been
commented with a proper description to be included automatically in the
sphinx build.
Change-Id: I36c9a86eabb9a297f75c9a4ca2bde8aaa0a1fcd3
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
Change-Id: Ia24af3f62fcb4de2bbe2004117afe3a6ede40762
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch adds the documentation directly in the sphinx role
documentation index. All variables have been commented with a proper
description to be included automatically in the sphinx build.
This patch also disables the fact gathering as this validation doesn't
use them at all.
Change-Id: I6e4b95faadf2e300030d476c75e6283237b43719
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch removes the README.md file and adds the documentation
directly in the sphinx role documentation index. All variables have been
commented with a proper description to be included automatically in the
sphinx build.
Change-Id: Icc9581821b5ba9c2bef7c0608d989e7044017ae6
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This change will allow all comments in our variable files to be rendered
normally within our documentation. This will allow folks reading our
documentation to benefit from information we may put in the various
files.
This patch adds ruamel.yaml as new dependency for building documentation
and we won't need to include a README.md file into the documentation
role index anymore.
Co-Authored-By: Kevin Carter <kecarter@redhat.com>
Change-Id: I82f68c1d78605e5b48df3d16461e4875d34890d0
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This patch moves all the contributing information from
doc/source/contributing.rst to CONTRIBUTING.rst file.
It also removes the installation.rst because we have the same content in
the readme.rst.
Change-Id: I87f992918e6db67d8182a1bcc3ba2637f922bcf5
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
We expect validations are used not only in upstream CI but also in
actual deployments when operators want to check status of their
deployments as part of daily check jobs, and having such message
would confuse operators because they might not understand what that CI
means and the log files mentioned are not created by TripleO.
Change-Id: I1d7e1d79f4689b14a0743bd42c27baf3379f54b0
This change resolves name collision and prevents possible
issues with the loop behavior, as noted by the warning:
The loop variable 'item' is already in use. You should set the
`loop_var` value in the `loop_control` option for the task to something else to
avoid variable collisions and unexpected behavior.
https://zuul.opendev.org/t/openstack/build/ed45cae1f67343ed875b6f7126ca80c9/log/job-output.txt#3713-3717
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Id5990bba88f37636f3884553968dcbeb5c4ea88a
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.
See https://tox.readthedocs.io/en/latest/config.html#conf-skipsdist
and https://github.com/tox-dev/tox/issues/1388 for details.
Change-Id: Icad8c8c48f7b34002a60aecc6b82e6ac56fd8a70
Several unnecessary imports were removed from test modules.
Imports of the validations_common.tests.fakes were kept.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I8d6d5057fa08be1ccd84c01837d6e4c93ce01b89
Presence of the string causes following error,
when running molecule tests on local:
'Error: error parsing host environment variables: name "PIP_+ VIRTUAL_ENV" has white spaces, poorly formatted name'
After removing it the molecule tests are able to run successfuly.
Furthermore I found no reference to the purpose of the string
in either the tox documentation, or by searching for the same
string on github. It appears we are the only project hosting code
on the service, using this particular setting.
I therefore assume that it is nonessential.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I61641a1d4ddd017451b4aa7aea1e6eae6439b53d
Json callback now expects the log directory to
be $HOME/validations. Just as defined in the validations libs.
Depends-On: https://review.opendev.org/c/openstack/validations-libs/+/795093
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Id1d39fd907eb154a601da68e9f75756cccfbf91c
The ansible 'reduce' function is itself imported from the functools:
https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/six/__init__.py#L273
And thus provides exactly the same functionality.
Furthermore, the functools is part of python lib since 2.7,
so the result should be compatible across all of our releases.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I981512fa81f0eb2aac0a50a4709c517cce794fa8
This patch updates the information about the `#tripleo` IRC channel
after the OFTC migration and adds our brand new channel at Libera named
`#validation-framework`.
Change-Id: I48e856b688b9e724ca49858d4aca0d3f32ca2de2
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
The variable storing start time of playbook run was named 't0'.
While perfecly fine from a functional standpoint,
and also in statistics and physics with subscript,
it is nonetheless a bit hard on the eye.
Tests were adjusted to reflect new var name.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Ie0796b1dcb8beacc08755fa04ff3cd4dd884ef59
This patch also adds molecule-podman driver as a requirement
because molecule >=3.2 stopped installing it by default.
Change-Id: Icf249d47496588a966ffd13b5affebada95d33d0
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
The usage of the component variable for the local and check jobs is
dangerous since this variable is used by the whole component chain for TripleO.
This review renamed it to validation_component.
Change-Id: Icd8e64282306479a84fc6240142ddcb28ce433e5
This patch relaxes the Jinja2 constraint since they recently released
the 3.0.1 and this latter is in the upper-constraints.
Related-Bug: #1929420
Change-Id: I55bd4ad75a925e5bdcb13b235dd2ee6f756ab318
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
All required packages now have licence listed
next to their respective designations.
Licence information was pulled from pip show command
or from package repository, in cases where pip didn't
offer sufficient information.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I296be2577c85a33c91e2156ec1b36762526d599c
Addition of .dockerignore considerably reduces the size
of newly created containers, as well as time needed for
building them.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Ifa94774862c2364483454a648377b0f333b72b99
Zuul job queries the requirements.txt and the relevant
spec file using the `rdopkg reqcheck` to find discrepancies
in the listed dependencies.
Just like the original `rdopkg-reqcheck` this job is non-voting.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I45043407b38bdcd0c0a38b30b65b5d5f70cae76d
fetch_validations role detects presence of the new
log folder, created via the new log path mechanism
introduced in the 36c9b8cbcbdfe35ba9b10b72c5b52a56c4ce9099
of the validations-libs.
The task should be removed once the related validations-libs
patch is safely merged.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I1a49dc16f65652ad7b1d9736d333c502d563870a
