openstack/cinder
Code Issues Proposed changes

Switch default py3x to py35

Browse Source 
Per our conversation in the Cinder weekly meeting [1] we will
now switch to just running local tests against python 3.5 as
that is the more recent and common 3.x version available on new
distros. Other versions can still be run explicitly, but this
changes the default tox run to only use 3.5.

[1] http://eavesdrop.openstack.org/meetings/cinder/2016/cinder.2016-11-30-16.00.log.html#l-54

Change-Id: If2226cb229f016e36c4dfab6224d5ae353b926bb
This commit is contained in:
Sean McGinnis 2016-12-09 14:22:28 -06:00
parent 863486f7a4
commit ca0786778c
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/devref/development.environment.rst
View File

@ -96,7 +96,7 @@ Running unit tests
------------------ ------------------
Run the unit tests by doing:: Run the unit tests by doing::
tox -e py34 tox -e py35
tox -e py27 tox -e py27
See :doc:`testing` for more details. See :doc:`testing` for more details.

16
doc/source/devref/testing.rst
View File

@ -86,7 +86,7 @@ More information about tempest can be found in the `Tempest Documentation
Running a subset of tests using tox Running a subset of tests using tox
----------------------------------- -----------------------------------
One common activity is to just run a single test, you can do this with tox One common activity is to just run a single test, you can do this with tox
simply by specifying to just run py27 or py34 tests against a single test:: simply by specifying to just run py27 or py35 tests against a single test::
tox -epy27 -- -n cinder.tests.unit.test_volume.AvailabilityZoneTestCase.test_list_availability_zones_cached tox -epy27 -- -n cinder.tests.unit.test_volume.AvailabilityZoneTestCase.test_list_availability_zones_cached
@ -116,9 +116,9 @@ can get around this by manually setting or updating the following line in
Note that you may use any location (not just ``/tmp``!) as long as it is not Note that you may use any location (not just ``/tmp``!) as long as it is not
a shared folder. a shared folder.
**Running py34 tests** **Running py35 tests**
You will need to install python3-dev in order to get py34 tests to run. If you You will need to install python3-dev in order to get py35 tests to run. If you
do not have this, you will get the following:: do not have this, you will get the following::
netifaces.c:1:20: fatal error: Python.h: No such file or directory netifaces.c:1:20: fatal error: Python.h: No such file or directory
@ -131,13 +131,13 @@ do not have this, you will get the following::
<snip> <snip>
ERROR: could not install deps [-r/opt/stack/cinder/test-requirements.txt, ERROR: could not install deps [-r/opt/stack/cinder/test-requirements.txt,
oslo.versionedobjects[fixtures]]; v = InvocationError('/opt/stack/cinder/ oslo.versionedobjects[fixtures]]; v = InvocationError('/opt/stack/cinder/
.tox/py34/bin/pip install -r/opt/stack/cinder/test-requirements.txt .tox/py35/bin/pip install -r/opt/stack/cinder/test-requirements.txt
oslo.versionedobjects[fixtures] (see /opt/stack/cinder/.tox/py34/log/py34-1.log)', 1) oslo.versionedobjects[fixtures] (see /opt/stack/cinder/.tox/py35/log/py35-1.log)', 1)
_______________________________________________________________ summary _______________________________________________________________ _______________________________________________________________ summary _______________________________________________________________
ERROR: py34: could not install deps [-r/opt/stack/cinder/test-requirements.txt, ERROR: py35: could not install deps [-r/opt/stack/cinder/test-requirements.txt,
oslo.versionedobjects[fixtures]]; v = InvocationError('/opt/stack/cinder/ oslo.versionedobjects[fixtures]]; v = InvocationError('/opt/stack/cinder/
.tox/py34/bin/pip install -r/opt/stack/cinder/test-requirements.txt .tox/py35/bin/pip install -r/opt/stack/cinder/test-requirements.txt
oslo.versionedobjects[fixtures] (see /opt/stack/cinder/.tox/py34/log/py34-1.log)', 1) oslo.versionedobjects[fixtures] (see /opt/stack/cinder/.tox/py35/log/py35-1.log)', 1)
To Fix: To Fix:

2
tox.ini
View File

@ -1,7 +1,7 @@
[tox] [tox]
minversion = 2.0 minversion = 2.0
skipsdist = True skipsdist = True
envlist = py34,py27,compliance,pep8 envlist = py35,py27,compliance,pep8
[testenv] [testenv]
# Note the hash seed is set to 0 until cinder can be tested with a # Note the hash seed is set to 0 until cinder can be tested with a