openstack/cinder
Code Issues Proposed changes

Dell EMC SC: Error Deleting Consistency Group

Browse Source 
Checking a return on something that doesn't return.

Closes-Bug:  #1752930

Change-Id: I5b6ae809814517657390b91878b917383eabd543
This commit is contained in:
Tom Swanson 2018-03-01 18:22:06 -06:00
parent b53574cfb7
commit e337cdd407
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/volume/drivers/dell_emc/sc/storagecenter_common.py
View File

@ -876,8 +876,9 @@ class SCCommonDriver(driver.ManageableVD,
for volume in volumes: for volume in volumes:
status = fields.GroupStatus.ERROR status = fields.GroupStatus.ERROR
try: try:
if self.delete_volume(volume): self.delete_volume(volume)
status = fields.GroupStatus.DELETED # We throw if that fails.
status = fields.GroupStatus.DELETED
except (exception.VolumeBackendAPIException, except (exception.VolumeBackendAPIException,
exception.VolumeIsBusy): exception.VolumeIsBusy):
LOG.error('delete_group: error deleting volume %s', LOG.error('delete_group: error deleting volume %s',