16296 Commits

Author SHA1 Message Date
Zuul
217d94d333 Merge "Set Nodeset to debian-bullseye for npm, integration and selenium job" 2022-12-04 03:23:18 +00:00
Zuul
19a0132ab2 Merge "Attach video even if the exception happens in cleanup" 2022-12-03 00:31:04 +00:00
Zuul
f59ba56268 Merge "Drop Nodejs v16 job" 2022-12-02 21:07:21 +00:00
manchandavishal
9a43c7964d Set Nodeset to debian-bullseye for npm, integration and selenium job
This patch changes nodeset to "debian-bullseye" from "ubuntu-focal" for
horizon-selenium-headless, horizon-nodejs, and horizon-integration-tests
jobs. Debian bullseye is also a runtime for the 2023.1 cycle as
mentioned here [1]. Right now if we change nodeset to "ubuntu-jammy"
all of the above jobs start failing. One possible solution to run these
jobs on "ubuntu-jammy" nodeset is to install firefox as a deb. package
instead of using snap as discussed here [2]. We can switch nodeset to
"ubuntu-jammy" in the future once the firefox issue with snap is fixed [3].

Also geckodriver version is upadted to latest(i.e. v0.32.0) to include
latest bug fix.

[1] https://governance.openstack.org/tc/reference/runtimes/2023.1.html
[2] https://meetings.opendev.org/irclogs/%23openstack-infra/%23openstack-infra.2022-11-23.log.html#t2022-11-23T14:15:08
[3] https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1951491

Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/865459

Related-Bug: #1996638

Change-Id: Ic50fbb8b29fc5dec42d1a5e94095c9777c7d5fb6
2022-11-29 17:00:31 +00:00
Zuul
b8648536c6 Merge "Fix preselection for launch Instance dialog" 2022-11-25 13:49:33 +00:00
manchandavishal
c832e239ba Drop Nodejs v16 job
As nodejs v18 job is passing in horizon and all horizon
plugins [1]. So we didn't require the nodejs v16 job.

This patch removes the nodejs v16 job definition from
``.zuul.d/nodejs-jobs.yaml`` and other nodejs v16 job
references.

[1] https://review.opendev.org/c/openstack/horizon/+/865293

Change-Id: I9e791c24944f228a27813eb860080d3ea3e1449d
2022-11-25 15:30:48 +05:30
Zuul
2f6b1e906a Merge "Setup project template for nodejs v18 jobs" 2022-11-23 22:53:47 +00:00
Tatiana Ovchinnikova
452c37dd36 Fix preselection for launch Instance dialog
Launch instance from a volumes/volume snapshot/instance snapshot
should open a dialog with preselected boot source. However the
dialog shows Image as selected boot source in any case, discarding
the preselection.

This patch fixes it, explicitly changing the boot source according to
the preselection.

Change-Id: I1a5a46d7be12ed179474a6a74647d0872b27b492
2022-11-23 15:48:24 -06:00
Zuul
bee42f9b1f Merge "Make readonly metadata properties unable to edit" 2022-11-23 20:51:30 +00:00
manchandavishal
bebc8dad2f Set Nodeset to ubuntu-focal for integration and selenium job
As openstack-tox jobs migrated from ubuntu focal to ubuntu
jammy[1]. So horizon integration and selenium-headless jobs
start failing. This patch changes the nodeset for both
these jobs to ubuntu focal as a workaround to unblock
the CI.

[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/861116

Related-Bug: #1996638
Change-Id: I674d7d3a8e1b34229fd5ef0285153e13324d3417
2022-11-22 18:50:35 +00:00
Radomir Dopieralski
6d7ecc1441 Attach video even if the exception happens in cleanup
The way we were handling attaching video in integration tests, it would
not attach it if the error happened in a cleanup, not in the main body
of the test. This should fix that.

Change-Id: I356e6849892ed87b2827740e265fcf15fc076cb5
2022-11-14 17:03:32 +01:00
Tatiana Ovchinnikova
892080ec0f Make readonly metadata properties unable to edit
Image metadata properties os_hash_algo and os_hash_value are
readonly, and attempts to edit them fail with unclear message.

This patch makes these fields readonly in update metadata form.

Also, if the existing metadata property is null, Horizon should
consider it optional too, in addition to empty field fix:
https://review.opendev.org/c/openstack/horizon/+/812009

Change-Id: I892465ca4688fce9f7123682d02f11c92c7d2c5c
2022-11-09 13:40:04 -06:00
Zuul
c319118d7d Merge "Imported Translations from Zanata" 2022-11-07 09:49:39 +00:00
OpenStack Proposal Bot
4af951f1b5 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I6784157d162a80866bf4001ebf9147b79ae0974a
2022-11-07 03:38:34 +00:00
OpenStack Proposal Bot
68d89e6981 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I1a67153ecf9afaf9fa16b78c721df74f158bc052
2022-11-05 03:55:11 +00:00
Zuul
e1ce2bb8e0 Merge "Fix flavor id auto generation" 2022-11-04 11:34:26 +00:00
Zuul
901975334b Merge "Make integration tests stop on first failure" 2022-11-03 17:42:56 +00:00
Jan Jasek
b14958df8b Fix instance error with attribute cells.
Selenium read data faster than the data are loaded.
Added wait until element is visible.

Change-Id: I2975ea5836a898d113a2baaab6a8f9bf8af8d742
2022-11-03 11:29:12 +01:00
manchandavishal
eaed7513ce Setup project template for nodejs v18 jobs
This patch defines job for for nodejs v18 which is the
next LTS version of nodejs[1] and also, the runtime for
the 2023.1 cycle[2]. The next step is to remove nodejs v16
jobs once nodejs v18 job passes for the horizon and its plugins.

[1] https://nodejs.org/en/about/releases/
[2] https://governance.openstack.org/tc/reference/runtimes/2023.1.html#node-js-runtime-for-2023-1

Depends-On: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/861876
Change-Id: I8caabe248b4a454f245aa2eedf36b2d63fd90e92
2022-11-03 07:24:48 +00:00
Tatiana Ovchinnikova
af7e6c4f75 Fix flavor id auto generation
Currently the flavor creation form always check for the uniqueness
of the UUID field, even when it is set to "auto". That means that if
we create a flavor with UUID value of "auto", the check will fail.

This patch disable the check when UUID is automatically generated.

Change-Id: Ie31307d67cf3857e3bb80c124e92c81e0c6a2982
2022-11-02 14:13:36 -05:00
Akihiro Motoki
516e57bc89 Add UT coverage for attach_interface by port
Previously attach_interface tests in project/instances/tests.py
did not cover the case of attach_interface by port.
This commit adds UT for such cases.

Details:
- The second call of the mocked network_list_for_tenant retured
  an empty list. It sounds tricky to change the return value for
  network_list_for_tenant() in two calls, but this trick was used
  to skip the processing of port_field_data.
  This should return a same value for the two calls to test
  port_field_data() function.
- To test the behavior of attach_interface by "port",
  an unbound port (whose device_owner/device_id of the port is empty)
  is required, so this commit adds it to neutron_data.py.
- test_interface_attach_get() covers a list of choices when "By Port"
  is selected in the form.
- test_interface_attach_post_by_port() is added.

Related to the addition of an unbound port to neutron_data.py,
the following other tests are adjusted.
They assumed that all non-network ports are owned by servers,
but it is no longer true as an unbound port is added to the test data.
Note that associating an unbound port with a floating IP is a valid
operation in neutron, so there is no problem to adjust UTs.

- openstack_dashboard/dashboards/project/floating_ips/tests.py
- openstack_dashboard/test/unit/api/test_neutron.py

Related-Bug: #1943639
Change-Id: Ib0ee342463e5668858078db43c04fe0a1be6e995
2022-10-26 15:34:17 -05:00
Zuul
a4718409f5 Merge "Fix rescue of volume-based instances" 2022-10-25 21:21:34 +00:00
Zuul
794472df8e Merge "Handle empty image_type in launch-instance workflow" 2022-10-23 00:57:27 +00:00
Zuul
fade123b22 Merge "Fix success_url parameter issue for Edit Snapshot" 2022-10-21 18:24:45 +00:00
Zuul
fc7374f493 Merge "Fix delete image tests." 2022-10-21 12:17:19 +00:00
Victor Coutellier
01afd1ba70 Handle empty image_type in launch-instance workflow
Fix the getImageType function to handle edge case
when image_type attribute is present but is an
empty string.

Closes-Bug: 1993579
Change-Id: Ie08cf1010d64ff927515b4792e9b052a76b6344d
2022-10-20 10:33:28 +02:00
OpenStack Proposal Bot
28349ee91b Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I938820bb4827b4bf578ed81182572ca878e96758
2022-10-18 03:58:00 +00:00
Jan Jasek
01c4ab920d Fix delete image tests.
Add wait until checkbox is in active state.

Fix edit_image_description_and_name test.
Add wait until the name text box is filled by default name (is not empty).
In the other case selenium write new name into text box faster than default
name is written there so default name then rewrite the new name.

Change-Id: I56803e19dd80180cc432ca872a28a7ee7f41290d
2022-10-17 17:13:04 +02:00
Radomir Dopieralski
4eb24797e5 Make integration tests stop on first failure
This should save us some time and decrease the server load. If a single
test failed, we already know the patch is bad (or the tests need to be
rerun) so it makes no sense to execute the rest of the tests on the
gate.

Change-Id: Ic56d5e192487d444afd0cdf0bce5e1a691ba087c
2022-10-12 16:21:36 +02:00
Rodrigo Barbieri
6eeaf98524 Fix app cred create without project_id for domain admins
Users with domain admin role that are not cloud admins are
not able to get scoped context and create an application
credential with project_id, so this change forces the
scoped context in that particular case.

Closes-bug: #1827120
Change-Id: I076a97a6f943ab74a2db8bc5179a7db194009db4
2022-10-11 07:43:06 +00:00
OpenStack Proposal Bot
a645545584 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic32b69d9f50860ef20b0c564e777cc738e0b2b81
2022-10-06 03:11:09 +00:00
Tatiana Ovchinnikova
d0e9e976f2 Fix flavor specification at instance overview page
The details page uses flavor id to resolve instance flavor, relying
on legacy Nova API v2.46. This patch adds the current Nova API
option, resolving instance flavor by flavor name, so flavor
specification at instance overview page is displayed properly.

Change-Id: I1fe45063c9d1cdd8682998329d81f843d30f80b3
2022-09-29 18:49:01 +00:00
Zuul
535171fbf9 Merge "Integration test navigation machinery for Angular pages" 2022-09-28 19:12:54 +00:00
Zuul
a0560b4bf5 Merge "Fix "Set admin password" checkbox visibility" 2022-09-27 08:58:18 +00:00
Tatiana Ovchinnikova
4743c6c748 Integration test navigation machinery for Angular pages
There's an implementation of navigation modules for pages written
in Angular.
Legacy tests for images page are rewritten to work with the new
navigation.

Change-Id: Ib8a40f0adb0a46c9d646c6796a4242988eefa6e3
2022-09-26 14:19:50 -05:00
OpenStack Proposal Bot
9443035163 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ib6e48db072cceed717a011c0a65e993c0a10aaf6
2022-09-24 03:17:58 +00:00
Zuul
65c69dd943 Merge "Switch to 2023.1 Python3 unit tests and generic template name" 2022-09-21 16:09:58 +00:00
Zuul
7b451666b8 Merge "Update master for stable/zed" 2022-09-21 15:01:05 +00:00
b832048287 Switch to 2023.1 Python3 unit tests and generic template name
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for antelope. Also,
updating the template name to generic one.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I57d369e1e1a84a2685e3eb157699e1262c996400
2022-09-21 12:08:30 +00:00
2da8878d6a Update master for stable/zed
Add file to the reno documentation build to show release notes for
stable/zed.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.

Sem-Ver: feature
Change-Id: I5ab71b2a53a7b18b719c4561cd0a48c3ef6ab5e4
2022-09-21 12:08:28 +00:00
OpenStack Proposal Bot
214b99304a Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Iabcaaf4f7454f5e481c6172297bc49a142494e60
2022-09-21 02:15:49 +00:00
Zuul
443134b54a Merge "Don't try and update port security if its not changing" 2022-09-20 17:43:01 +00:00
Zuul
34b2e82343 Merge "volume-backup add incremental flag" 23.0.0 2022-09-20 06:43:09 +00:00
Zuul
0850f71df6 Merge "Allow volumes in error_restoring/error_managing to be deleted" 2022-09-19 22:59:07 +00:00
Zuul
c884f79e76 Merge "Sync default policy rules" 2022-09-19 21:18:42 +00:00
Zuul
e53f5ce8fb Merge "Fix redirect after deleting from details page" 2022-09-19 18:25:33 +00:00
Zuul
fee268dd89 Merge "Drop Nodejs14 job" 2022-09-19 18:21:35 +00:00
Zuul
b350b580f3 Merge "Update Xstatic-angular version in `requirements.txt`" 2022-09-19 12:06:27 +00:00
Zuul
753a19cdfb Merge "Use SetUp and cleanup for the network pagination tests" 2022-09-16 20:28:31 +00:00
manchandavishal
79d1395942 Fix success_url parameter issue for Edit Snapshot
The "success_url" param is used when updating the project snapshot
[1] and it lacks sanitizing the input URL that allows an attacker to
redirect the user to another website. This patch update 'Updateview'
class to not use the "sucess_url" method.

Closes-bug: #1982676

[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/snapshots/views.py#L109

Change-Id: Ied142440965b1a722e7a4dd1be3b1be3b3e1644b
2022-09-14 22:23:27 +05:30