Use tuples instead of lists as it will be more difficult for developers
to accidentally overwrite/modify the variables.
This was inspired by commit 338651eae5b7c416f04970b9d60f09dc2dab8adb
which was fixing an issue where the base class variables were being
modified accidentally.
Change-Id: Ib7d67580ca377fabeb958c68a4d0d9bd2e2fd33a
core_interfaces and standard_interfaces are both static members of BaseDriver
we need to take a copy of them before appending to them.
Change-Id: Ic6edc5e49a25849c7871dbc9e6e1d5a5eb229e57
Closes-Bug: #1672457
This patch defines min_microversion for API portgroup tests to
skip them when this API version is not supported/available.
For example on stable/mitaka branches.
Change-Id: I8895e1e6a819b5b3821fdfc10e1cff8626c9eb29
Add more checks to the test_vifs test:
- check that attached VIF appears in port internal_info;
- check that VIF was detached and does not appear in
node's VIF list anymore.
Add test for VIF attachement to node with portgroup.
Partial-Bug: #1666534
Change-Id: I755df18e03d01fe93f85df114b979ea7ea70ca53
As part of the commit 7fd26bf8031041a0e6df261c71101e29e8bf9610,
logging was moved to ironic.conf.__init__.py. This seems to be
the reason of the config options not being logged anymore.
Closes-Bug: #1674707
Change-Id: I566c9383a3979ad8f6373fb5ef918d0e06e3a53f
When installing virtualbmc, take into account the requirements and
constraints from openstack/requirements.
Change-Id: I61a9279ae5ab12fd0415fdfbc5a696250c0bd09d
Updates ``dev-quickstart.rst`` by adding instructions required
to install sqlite development headers while building python3.5
on Ubuntu
Change-Id: I2bb9bc2a62947d2cf1d6287e66fc973afab4d1f7
Remove all calls to logging functions from the db directory of ironic.
In this instance, there were very few, and all were to _LW.
Change-Id: I474f2d51bf7cb9d6082d963de182d4a1fed142b3
Partial-bug: #1674374
add back some methods that were pruned. They are used in tests running
on stable branches.
Change-Id: I2e0c979f870777d3f643ab8b87c5b1f0b9601c34
Closes-Bug: #1674597
Adds two tests that uses direct HTTP link instead of glance:
* pxe_ipmitool + wholedisk on HTTP server
* agent_ipmitool + wholedisk on HTTP server
Change-Id: I8f1a5b0ecb3d53ffdefd7018c1b9700210572ffc
In order to have Ironic installed using Python 3 when running under a
Python 3 test job, we need to enable it as a Python 3 package.
The Python 3 job still doesn't pass. But this is needed as part of the
work.
Change-Id: I6a766bbb4250d76d458db8783631e4bd834859f3
Those are remnants from the oslo-incubator times. Also, oslo.messaging
deprecated [1] transport aliases since 5.2.0+ that is the minimal
version supported for stable/newton. The patch that bumped the minimal
version for Ironic landed 3 months+ ago, so we can proceed ripping
those aliases from the code base.
[1] I314cefa5fb1803fa7e21e3e34300e5ced31bba89
Change-Id: I42dcc4b64f0b8e667abad68f7a5ed1ba004ec329
Closes-Bug: #1424728
the reference file must be opened in binary mode,
otherwise under Py3 it fails to update checksum with exception
`Unicode must be encoded before hashing`.
Change-Id: I3162fe9951750f5a41ef403b9a10ed68c0ba958a
Our unittest output complains about some of the codebase,
described in more detail in the referred bug. This change
fixes all of those places.
static_root is now set only if debug=True is set in pecan
configuration.
Logging is now setup as part of the conf module import,
so that unittests can use it.
Closes-Bug: #1668240
Change-Id: I2536bd2b174e0d224ddf6806f1be37bd29017669
Remove unused code from manager.py to better identify ironic
dependencies on this tempest interface. This is a follow-up
patch to https://review.openstack.org/#/c/439252/.
Change-Id: I3ca7cf3af42e0e55431d5affa36e567f147aa850
Specify 'ironic' as the name of the application for the flake8-import-order
plugin. That way it knows that imports of ironic should come after external
libraries.
Change-Id: I3e6fb237b9846e8de1a071f3a659c23c44bc7f75
This commit updates the proliantutils version required in Ironic
to 2.2.1. This version of proliantutils includes HPSUM firmware
update support and updation of requirements to match
global-requirements (required to fix third party CI gate jobs)
Change-Id: Ife96638b6262d22b3aa82155df3d7e4f525bd22b