13383 Commits

Author SHA1 Message Date
Matt Crees
e0191cb167 Add check_mode: false to Nova upgrade checks
The step "Run Nova upgrade checks" needs to be excluded from check mode.

Related-Bug: #2002657
Change-Id: Ida582606b03d1896a6c58d4b324d088dc3b71852
2023-04-19 16:19:59 +01:00
Zuul
9cfba97cf5 Merge "Use the upgraded image to run Nova upgrade checks" 2023-04-19 14:16:19 +00:00
Zuul
f5991df02b Merge "mariadb: add mariadb_datadir_volume parameter" 2023-04-19 08:27:42 +00:00
Zuul
17aa380bf8 Merge "ansible: bump min to 2.13 and max to 2.14" 2023-04-19 01:26:28 +00:00
Zuul
fab40de52f Merge "Remove RabbitMQ ha-all policy when not required" 2023-04-18 20:24:54 +00:00
Zuul
7a8f3d3212 Merge "Fix create sasl account before config file is ready" 2023-04-18 18:57:00 +00:00
Zuul
52611ecbab Merge "Fix maximum width of the DIB Multiline-YAML" 2023-04-18 14:51:39 +00:00
Michal Nasiadka
c0a45c7eb7 opensearch: default dashboards tag to opensearch_tag
Closes-Bug: #2016627

Change-Id: I5ae1d911c5df423e0b70dab306709320083b7b69
2023-04-17 12:37:33 +00:00
Maksim Malchuk
47862b56bd Fix maximum width of the DIB Multiline-YAML
The dib_env_vars variable in the Bifrost's dib.yml file can contain
the DIB_BLOCK_DEVICE_CONFIG environment variable which is always the
Multiline-YAML data. By default, the format of the data is not
preserved while the configuration is merged and saved for the
bifrost-deploy container.

This is because Ansible uses the PyYAML library which has a default
80 symbol string length limit. The official Ansible documentation [1]
recommends using to_yaml or to_nice_yaml filters with width parameter.
This change adds the same ability to the merge_yaml Ansible plugin.

1. https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#formatting-data-yaml-and-json

The related change for the diskimage-builder to solve the issue with
incorrect data provided by Kolla-Ansible is also provided:
I3b74ede69eb064ad813a9108ec68a228e549e8bb

Closes-Bug: #2014980
Related-Bug: #2014981
Change-Id: Id79445c0311916ac6c1beb3986e14f652ee5a63c
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-14 16:36:22 +03:00
Zuul
b142b0ae7a Merge "Fix merge action plugins verbose output" 2023-04-14 10:36:45 +00:00
Zuul
be2e353da3 Merge "RabbitMQ use maintenance mode on container restart" 2023-04-13 21:47:41 +00:00
Zuul
4b27d19b63 Merge "Set RabbitMQ ha-promote-on-shutdown=always" 2023-04-13 15:05:48 +00:00
Michal Nasiadka
9867060b6b ansible: bump min to 2.13 and max to 2.14
Change-Id: Ibc9cc91f64b0450de3cae6e2830b4ff2c52c0395
2023-04-13 14:10:28 +00:00
Matt Crees
c85b64d158 Remove RabbitMQ ha-all policy when not required
With the addition of the variable
`om_enable_rabbitmq_high_availability`, this feature in the upgrade
task should be brought back. It is also now used in the deploy task. The
`ha-all` policy is cleared only when
`om_enable_rabbitmq_high_availability` is set to `false`.

Change-Id: Ia056aa40e996b1f0fed43c0f672466c7e4a2f547
2023-04-13 15:58:15 +02:00
Matt Crees
e709599ff0 RabbitMQ use maintenance mode on container restart
Puts the RabbitMQ node into maintenance mode before restarting the
container. This will make the node shutdown less disruptive. For details
on what maintenance mode does, see:
https://www.rabbitmq.com/upgrade.html#maintenance-mode

Change-Id: Ia61573f3fb95fe8fcde6b789ca77ef5b45fe0a65
2023-04-12 15:58:17 +01:00
Michal Nasiadka
b30c7bc87b rabbitmq: Do not stop containers on upgrade
Since RMQ 3.8 we can use rolling upgrade [1].

Depends-On: https://review.opendev.org/c/openstack/kolla/+/872393

[1]: https://www.rabbitmq.com/upgrade.html#rolling-upgrades

Change-Id: If6a7c6c12d9226a2406728108b3c87b3485ac55f
2023-04-12 11:12:30 +00:00
gamerslouis
46415123d5 Fix create sasl account before config file is ready
Add checking for container readiness before create sasl user

Closes-Bug: #2015589
Change-Id: Ic650ba6be1f192e3cbeaa94de3d00507636c1c92
2023-04-08 17:48:46 +00:00
Zuul
717eb8c14f Merge "nova: Fix live migration on RHEL9 derivatives" 2023-04-03 14:31:39 +00:00
Michal Nasiadka
7c32e6f3b3 nova: Fix live migration on RHEL9 derivatives
Closes-Bug: #2005119
Change-Id: I542f7ae19b4400355b04854f42a1d1802a6efeea
2023-04-03 10:28:48 +00:00
Zuul
3e556dad61 Merge "Add LimitRequestBody configuration for Horizon" 2023-04-03 10:25:55 +00:00
Maksim Malchuk
8972241dc9 Fix merge action plugins verbose output
This change fixes the output 'module_args' information of the plugins
'merge_configs' and 'merge_yaml' when Ansible is executed in maximum
verbose mode. Now all the plugin options are displayed instead of
standard 'copy' plugin options only.

Also, this change contains fixes already applied in the Kayobe
project to improve and synchronize the code of the plugins between
projects.

Change-Id: Ie2d9a0501fe29bfd854eb31258f282b197855948
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-02 00:33:40 +03:00
Zuul
dbb4f3d0ae Merge "Add neutron_ovn_availability_zones parameter" 2023-03-29 16:48:23 +00:00
Zuul
0b7ed4dad9 Merge "[CI] Test Neutron with IPv6 networks" 2023-03-29 13:47:54 +00:00
Maksim Malchuk
d907790fff Add LimitRequestBody configuration for Horizon
Since CVE-2022-29404 is fixed [1,2] the default value for the
LimitRequestBody directive in the Apache HTTP Server has been changed
from 0 (unlimited) to 1 GiB. This limits the size of images (for
example) uploaded in Horizon. This change add the ability to
configure the limit.

1. https://access.redhat.com/articles/6975397
2. https://ubuntu.com/security/CVE-2022-29404

Closes-Bug: #2012588
Change-Id: I4cd9dd088cbcf38ff6f8d188ebcc56be7d9ea1c9
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-03-29 14:51:28 +03:00
Zuul
406a090f3d Merge "Add note about removing leading tabs in ceph.conf files" 2023-03-29 11:37:14 +00:00
Tom Fifield
9070c4fa9d Add note about removing leading tabs in ceph.conf files
As reported in bug #1914814, common ways to generate ceph config files
result in files that have leading tabs. These tabs make Kolla Ansible's
ini parser unhappy, so add a note to remind users to remove them.

Closes-Bug: #1914814
Change-Id: I4b06eae75bf238f2f093bfb76ba37c7f75dfd616
2023-03-28 13:07:14 +00:00
Matt Crees
e34fbb174c Use the upgraded image to run Nova upgrade checks
When upgrading Nova, we sometimes hit an error where an old hypervisor
that hasn’t been upgraded recently (for example due to broken hardware)
is preventing Nova API from starting properly. This can be detected
using the tool ``nova-status upgrade check`` to make sure that there are
no ``nova-compute`` that are older than N-1 releases. This is already
used in the Kolla Ansible upgrade task for Nova. However, this task uses
the current ``nova-api`` container, so computes which will be too old
after the upgrade are not caught.

This patch changes Kolla Ansible so that the upgraded ``nova-api`` image
is used to run the upgrade checks, allowing computes that will be too
old to be detected before the upgrades are performed.

Depends-On: https://review.opendev.org/c/openstack/kolla/+/878744

Closes-Bug: #1957080
Co-Authored-By: Pierre Riteau <pierre@stackhpc.com>
Change-Id: I3a899411001834a0c88e37f45a756247ee11563d
2023-03-28 09:11:46 +02:00
Zuul
da48d99eef Merge "magnum: Fix trustee creation after ansible-collections-openstack bump" 2023-03-27 09:20:25 +00:00
Radosław Piliszek
7367427338 [CI] Test Neutron with IPv6 networks
Make sure to actually test IPv6 connectivity to our test instance in the
IPv6 jobs.

Change-Id: I7845448804e191af356e82f8ad33c563ffd8ebd5
2023-03-26 09:34:53 +00:00
Zuul
4971eccd62 Merge "Set RabbitMQ message TTL and queue expiry" 2023-03-24 16:28:43 +00:00
Zuul
ad744874c9 Merge "Add flags for RabbitMQ message TTL & queue expiry" 2023-03-24 16:20:29 +00:00
Michal Nasiadka
8dd409ceaf magnum: Fix trustee creation after ansible-collections-openstack bump
Change-Id: I54e68a3002d69f7b1be2704259c6a072f81aa586
2023-03-23 16:18:58 +00:00
Michal Nasiadka
cdcf622018 Fix restart_container when restart_policy is no
Closes-Bug: #2012654

Change-Id: I9735b4409a48d80851cbc26a9edbf370af1d45bf
2023-03-23 16:18:34 +00:00
Zuul
2845861ef9 Merge "Fix deploy/genconfig in check mode" 2023-03-23 10:55:24 +00:00
John Garbutt
fd30dfb867 Set RabbitMQ message TTL and queue expiry
Following ideas here:
https://wiki.openstack.org/wiki/Large_Scale_Configuration_Rabbit

Make sure old messages with no consumer are dropped after the message
TTL of 10 mins, longer than the 1 min RPC timeout.
Also ensure queues expire after an hour of inactivity, so queues from
removed nodes or renamed nodes don't grow over time.

Change-Id: Ifb28ac68b6328adb604a7474d01e5f7a47b2e788
2023-03-21 09:11:41 +00:00
Matt Crees
dae2cbca30 Add flags for RabbitMQ message TTL & queue expiry
Adds two new flags to alter behaviour in RabbitMQ:
    * `rabbitmq_message_ttl_ms`, which lets you set a TTL on messages.
    * `rabbitmq_queue_expiry_ms`, which lets you set an expiry time on queues.
See https://www.rabbitmq.com/ttl.html for more information on both.

Change-Id: I51ca37ffbb1bb5c07f2d39873f0f33ca20263f2a
2023-03-21 09:10:56 +00:00
Matt Crees
a87810db7e Set RabbitMQ ha-promote-on-shutdown=always
Changes the default value of `rabbitmq-ha-promote-on-shutdown` to
`"always"`.

We are seeing issues with RabbitMQ automatically recovering when nodes
are restarted. https://www.rabbitmq.com/ha.html#cluster-shutdown

Rather than waiting for operator interventions, it is better we allow
recovery to happen, even if that means we may loose some messages.
A few failed and timed out operations is better than a totaly broken
cloud. This is achieved using ha-promote-on-shutdown=always.

Note, when a node failure is detected, this is already the default
behaviour from 3.7.5 onwards:
https://www.rabbitmq.com/ha.html#promoting-unsynchronised-mirrors

Related-Bug: #1954925
Change-Id: I484a81163f703fa27112df22473d657e2a9ab964
2023-03-21 09:08:42 +00:00
Michal Nasiadka
94a74f58c7 Pin zun jobs to Docker 20
Related-Bug: #2007142

Change-Id: I9ce2a9ce5413e77625201f3986967e31a679ad9c
2023-03-21 08:34:31 +00:00
Zuul
0d42110e01 Merge "Improve RabbitMQ performance by reducing ha replicas" 2023-03-20 12:17:42 +00:00
Zuul
13f4f78c6f Merge "Add flag to change RabbitMQ ha-mode definition" 2023-03-20 11:52:43 +00:00
Zuul
648870d275 Merge "RabbitMQ: Support setting ha-promote-on-shutdown" 2023-03-20 11:50:47 +00:00
Zuul
d6bfec4ad2 Merge "cloudkitty: set cafile for fetcher_keystone" 2023-03-20 10:41:19 +00:00
Michal Nasiadka
f5b3f9d22b ironic: fix dev mode for inspector
Change-Id: I1649a389bdc3977b936402c3ce3e55056d74ba08
2023-03-15 09:44:35 +00:00
Piotr Parczewski
c971799db3 Update Stackalytics links
Change-Id: Icf1a30e8da7f71a8bcf2a9cc35a8d006e7a59f8d
2023-03-14 09:35:38 +01:00
Zuul
76268b7221 Merge "iscsi: Use assert on checks for readability" 2023-03-12 13:50:01 +00:00
Zuul
21e2434b59 Merge "etcd: Set the proper peer and client protocol when tls is enabled" 2023-03-09 08:06:05 +00:00
Zuul
f565011d98 Merge "Set the etcd internal hostname and cacert for tls internal enabled deployments" 2023-03-08 18:36:46 +00:00
Christian Berendt
b327ae4a56 mariadb: add mariadb_datadir_volume parameter
With the parameter ``mariadb_datadir_volume`` it is possible
to use a directory as volume for the mariadb service. By default,
a volume named mariadb is used (the previous default).

Change-Id: Ic61fe981825c5fa6f50e53c9555b6a102f42f522
2023-03-06 23:45:23 +01:00
Christian Berendt
6768b760ab Add neutron_ovn_availability_zones parameter
With the new ``neutron_ovn_availability_zones`` parameter it is possible
to define network availability zones for OVN. Further details can be found
in the Neutron OVN documentation:
https://docs.openstack.org/neutron/latest/admin/ovn/availability_zones.html#how-to-configure-it

Change-Id: I203e0d400a3218d0b4a41f2a948207032c4febec
2023-03-06 13:28:28 +00:00
Matthew N Heler
5d3eed23a7 Set the etcd internal hostname and cacert for tls internal enabled
deployments

This allows services to work with etcd when coordination is enabled
for TLS internal deployments. Without this fix, we fail to connect to
etcd with the coordination backend and the service itself crashes.

Change-Id: I0c1d6b87e663e48c15a846a2774b0a4531a3ca68
2023-03-02 06:48:40 -06:00