In https://review.openstack.org/#/c/436958, we fix a thread safety
issue. But we make the ack/requeue of message asynchronous. In nominal
case, it works, but if network/rabbit connection issue occurs this
can result to rpc call handle twice. By chance we double check already
processed message ids, and drop duplicates, but that if the message
goes to another node, the mitigation won't work.
This restore the previous behavior, to ensure we run application
callback of rpc.call/rpc.cast only when the message have been
successfully ack.
Change-Id: I62b9e09513e3ebfebc64a941d4b21b6c053b511d
The get_rpc_transport wraps get_transport to unify the API in
anticipation of comprehensive separation of RPC and Notification
messaging backends.
Related-Bug: 1680192
Change-Id: Ic6af07b98ff43806c2af38a3ba129991f1e0ec86
Something broke in the way SSL certs are generated. Disable these
tests for now to unblock the gate.
Change-Id: I9764da7995c198597661ecbea27efba9f76e53e3
Right now two tests mock logging module globally which leads to
another test failure (TestRoutingNotifier.test_notify_filtered)
on my env.
Change-Id: Ifa47ee96dae79ea44dbe17a2d125401589ff13dd
OpenStack projects should be using mock rather than mox.
oslo.messaging was using mox's stubs via oslotest rather than
mock.patch.object. The code is converted to use mock.patch.object
via fixtures.MockPatchObject.
Change-Id: I19490b4e8211c35b237ebfd38bf2f8b8b44cbf61
We log deprecation message even if application doesn't use it.
And we missing the parse method.
This change fixes that.
Change-Id: I476816cb14ac8218feb74e8459cfa5f18fdb6c61
Last oslo.config was magically converting MultiStrOpt "messaging" to ["messaging"],
that was not expected, oslo.messaging have a test that use "messaging"
instead of a list.
This change fixes that.
Change-Id: I65b8cc551dde6f80d979640ba3db097572f3fe9b
When the underlying RPC is configured with rabbit along
with oslo_messaging_notifications, currently the retry is
not supported. There are retry support specific to drivers,
it's better to have the support uniform across the drivers,
by adding configuration retry on the oslo_messaging_notifier.
Closes-bug: 1666364
Change-Id: I8d547ef2a9e8b086f94a1efca17735f3f3cdaac1
We deprecate and change parameter enforce_type's default value
to True[1], so don't need usage enforce_type.
[1] https://review.openstack.org/328692
Change-Id: Ib89cb9bc8afa13e13350e80ec9210ab9e878201f
Use https instead of http to ensure the safety without containing our
account/password information
Change-Id: I0ffb9e2270bbae844c187fdc17610e7805553d66
The pre-settled configuration option was being ignored in the case of
RPC call transfers.
Change-Id: I35989c8a653bac0d9a7c3e33a8af2027574f4bd9
Closes-Bug: 1680905
When running the tests with concurrency=1, 2 tests fail with:
AttributeError: Mock object has no attribute 'debug'
and
AssertionError: Expected 'notify' to be called once. Called 0 times
Mocking the LOG object solves the problem.
Change-Id: Ie7f4448a103fae448123a05bc92e961aac00d6ec
Closes-Bug: #1660393
This uses the underlying x-ssl option that will attempt an SSL
connection to the server using the system's CA bundle.
Change-Id: I73f3b43b4ebc0c4ce4c0ba43b5a84361fb308686
* add application scenario to help of config option
'executor_thread_pool_size'
* Move eventlet patched checking to constructor
Change-Id: I9dc7c993c8947b51952365cc5e7b6f2daae6bb70
