Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.
Change-Id: I6deee90c31adf61d80e2678a5f29ba9e187281c9
In novaclient/shell.py there is a variable called 'password_fun'
which isn't used anywhere.
In fact it's a spelling miss, and should be modified to 'password_func'
which is used in novaclient/client.py
This patch fixes this bug.
Change-Id: Ibb8e95a2efc77575dcc8544584c708c5c62b7dea
"Aggregate %s has been successfully updated." as the print message of
do_aggregate_set_metadata/do_aggregate_add_host/do_aggregate_remove_host
is incorrect.
Change-Id: I18c1c3a4403a8ebe3062ef7a695b0e643619dc74
nova quota-update doesn't support update '--gigabytes' and '--volumes', but
CLI include these two parameter, so it should remove these two parameter
from novaclient
Change-Id: I9db39dd397ba3368f214377f37b56ac4f4f3864c
Closes-bug: #1277673
* tox.ini: The LANG and LANGUAGE environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug.
Change-Id: I0f30b45033145c61ad2a9b232cb1178c48c7fc97
Hyper-V employs RDP to access virtual machine consoles, unlike most
other hypervisors which support VNC.
In order to support this scenario, the get_rdp_console API has been
added to Nova. This commit adds the corresponding client side feature,
implemented in a way consistent with existing VNC and SPICE console
support.
Nova Gerrit commit: https://review.openstack.org/#/c/43502/
Change-Id: I86b814797d234f1eb49a7fa67ed27a9bcda034ae
Implements: blueprint hyper-v-rdp-console
+ Added unit test to test that poll method is called.
Testing of poll method itself is out of this CR scope.
Change-Id: I57adb80bacd76b0831ea63f74182f60a2033ab11
When we str(service_object), an AttributeError occurred like this:
========================
File "/opt/stack/python-novaclient/novaclient/v1_1/services.py", line
24, in __repr__
return "<Service: %s>" % self.service
File
"/opt/stack/python-novaclient/novaclient/openstack/common/apiclient/base.py",
line 463, in __getattr__
raise AttributeError(k)
AttributeError: service
========================
This commit fixes it.
Change-Id: I496d522591273bf1b1e7dbadf19afaf5e64e41e3
Closes-Bug: #1276408
It seems that author wanted to return two pools. But because of typo,
method now returns only one of them. Fixed typo to return two pools.
Change-Id: Ia77a8529fd4db1b06860073ebf33bd54b43438cd
Python takes only the last value if several keys with the
same name listed. Removed the first one to make value evident.
Change-Id: I6cef783ff245073b4c0fde0e4d60ff69fb02fc22
* Positive test was calling the same check several times. Replaced
with one call.
* Negative test was failing with "'object has no attribute 'assertFail'"
error message in case of failure. Replaced with appropriate message.
Change-Id: Id03a452f7735d6b4d13f54036f1bd3ae50cb487a
This change applies a regular expression in order to filter
flavor extraspects keys with invalid characters.
The characters allowed are: letters, numbers, underscores,
periods, colons, spaces and hyphens.
A new test flavor has been created which doesn't check the
keys in the post body. This flavor has been created in the
third place (instead of in the last) in order to keep
working existent test cases which depend on the last flavor
received in the get method.
Change-Id: Ifd86bed23a05a5946ae8b9ba6f6c9bf4b24b1d4c
Partial-Bug: #1256119
There was a call from install_venv.py file to post_process method
of InstallVenv class, but this method is not defined in this class
as result it was raising an error. Even when this error doesn't
affect dependencies installation, it is not allowing to display user
information.
Change-Id: I499c0399eb961588d7e1491e1481412ffdda38b8
Closes-Bug: #1275025
This change make all the text visible by the user i18n. The
messages changes are in prints, logs, exceptions, helps, etc
Pep8 errors about "Multiple positional placeholders" also fixed
Change-Id: I731afea790baddbc34d059b93a35e3d275fc1df8
Creates an images client when attached to the the servers
client. This is necessary because the Nova V3 API no longer
proxies image queries to glance but when preparing a request to
boot a server it is necessary to retreive information about
images so we need to talk to both Nova and Glance in the same
command.
This is a bit ugly, but not much more than the already existing
ugliness of using the client class designed to talk to
Nova to talk to Glance and Cinder. The long term clean solution
is probably to a unified client that is designed to talk to
multiple openstack services.
Differences between the V2 and V3 API are described here:
https://wiki.openstack.org/wiki/NovaAPIv2tov3
Partially implements blueprint v3-api
Change-Id: Ib43682f38cd7a3e0f910b75e96685591246e7f67
Removes the volume commands which are not supported by the V3 API.
They are removed only from the V3 part of novaclient and so
the V2 support remains the same.
Partially implements blueprint v3-api
Change-Id: I343885c72e7cd020060249ece61135eacab68039
All methods of Resource class novaclient is equal to common code.
In the process of unification of the clients code we should
reuse common functionality from Oslo.
Related to blueprint common-client-library-2
Change-Id: I2b72c6b34a44dec3572ca8ad70e41e42a32d48c0
This patchset updates modules based on the config file:
openstack-common.conf
Notes: Some corrections has been added to work with
new files.
+ utils.py: The method safe_decode from strutils.py
was updated and it is now not necessary to check for
decode string with py33.
+ base.py: base64 needs a 8-bit string for py33
+ test_shell.py: stdin.encoding is needed for strutils
Change-Id: Iebe474f1226f8b5faa7fb5722e65f41b80d1973c
Related to blueprint common-client-library-2
Closes-Bug: #1265473
There are some common methods in cliutils we can use in novaclient:
arg, env, unauthenticated, isunauthenticated.
+ Replaces utils.env to add alias env from cliutils.
+ Replaces utils.arg to add alias arg from cliutils.
+ Removes unused methods: add_arg, unauthenticated, isunauthenticated
To use methods from clituils.
Related to blueprint common-client-library-2
Change-Id: Ic7c132c37d6a91cf3eae55530300efd153c31903
Method shell._boot uses class basestring instead of six.string_types.
Tests don't check this method with several hints, so we didn't have
NameError in py33 env.
Change-Id: I9b35cd7ba162140a15929f9fc8a6d21755b3570c
